8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

[sendaoYan]

Hi all,
This PR try to fix linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src. The libiberty.a locates in build/linux-x86-server-fastdebug/configure-support/binutils-install/lib32 on linux ubuntu20. The change has been verified, the risk is low.

Additional testing:

• linux x86_32 centos7 configure
• linux x86_64 centos7 configure
• linux x86_32 ubuntu20 configure
• linux x86_64 ubuntu20 configure

configure-linux-centos7-x86_32.log
configure-linux-centos7-x86_64.log
configure-ubuntu20-x86_32.log
configure-ubuntu20-x86_64.log

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src (Bug - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 16b59a95
• Julian Waters (@TheShermanTanker - Committer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19511/head:pull/19511
$ git checkout pull/19511

Update a local copy of the PR:
$ git checkout pull/19511
$ git pull https://git.openjdk.org/jdk.git pull/19511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19511

View PR using the GUI difftool:
$ git pr show -t 19511

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19511.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333128: Linux x86_32 configure fail with --with-hsdis=binutils --with-binutils-src

Reviewed-by: shade, jwaters, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• f0bffbc: 8333301: Remove static builds using --enable-static-build
• b101586: 8332514: Allow class space size to be larger than 3GB
• 5ed0d52: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
• 91101f0: 8333353: Delete extra empty line in CodeBlob.java
• e0ac824: 8332959: C2: ZGC fails with 'Incorrect load shift' when invoking Object.clone() reflectively on an array
• d2d78ad: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
• 7c83d7a: 8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure
• 75220da: 8333154: RISC-V: Add support for primitive array C1 clone intrinsic
• a4c7be8: 8333006: RISC-V: C2: Support vector-scalar and vector-immediate arithmetic instructions
• cfe91ed: 8333276: RISC-V: client VM build failure after JDK-8241503
• ... and 2 more: https://git.openjdk.org/jdk/compare/4785461f61d8f5c7444d2e6fd90f1e083dbc6fe4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev, @TheShermanTanker, @magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (24e5cf45)
• 00: Full (16b59a95)

[sendaoYan]

/issue JDK-8333128

[openjdk]

@sendaoYan This issue is referenced in the PR title - it will now be updated.

[shipilev]

This makes sense, thanks.

[sendaoYan]

Does this pull request needs 2rd review.

[shipilev]

Not formally, IIRC, since it looks trivial. But I think @magicus or @erikj79 would see it soon, and the reviewer count question would be moot.

[TheShermanTanker]

Don't forget about me! :)

[shipilev]

Don't forget about me! :)

Ah yes, you are also in Build Group now! Apologies.

[TheShermanTanker]

Don't forget about me! :)

Ah yes, you are also in Build Group now! Apologies.

No worries, I was joking lightheartedly :P

[sendaoYan]

Thanks all for the review.
/integrate

[openjdk]

@sendaoYan
Your change (at version 24e5cf4) is now ready to be sponsored by a Committer.

[TheShermanTanker]

/sponsor

[openjdk]

Going to push as commit d07e530.
Since your change was applied there have been 12 commits pushed to the master branch:

• f0bffbc: 8333301: Remove static builds using --enable-static-build
• b101586: 8332514: Allow class space size to be larger than 3GB
• 5ed0d52: 8332936: Test vmTestbase/metaspace/gc/watermark_70_80/TestDescription.java fails with no GC's recorded
• 91101f0: 8333353: Delete extra empty line in CodeBlob.java
• e0ac824: 8332959: C2: ZGC fails with 'Incorrect load shift' when invoking Object.clone() reflectively on an array
• d2d78ad: 8280990: [XWayland] XTest emulated mouse click does not bring window to front
• 7c83d7a: 8333366: C2: CmpU3Nodes are not pushed back to worklist in PhaseCCP leading to non-fixpoint assertion failure
• 75220da: 8333154: RISC-V: Add support for primitive array C1 clone intrinsic
• a4c7be8: 8333006: RISC-V: C2: Support vector-scalar and vector-immediate arithmetic instructions
• cfe91ed: 8333276: RISC-V: client VM build failure after JDK-8241503
• ... and 2 more: https://git.openjdk.org/jdk/compare/4785461f61d8f5c7444d2e6fd90f1e083dbc6fe4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheShermanTanker @sendaoYan Pushed as commit d07e530.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

/sponsor

Thanks for the sponsor.