8329335: HttpsURLConnectionTest fails due to network firewall rules #19745
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HttpsURLConnectionTest attempts to reach external servers, it can fail if run on hosts without outbound traffic allowed. Therefore, it should not be executed in CI pipelines but rather manually on a host with no firewall rules preventing egress traffic.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19745/head:pull/19745
$ git checkout pull/19745
Update a local copy of the PR:
$ git checkout pull/19745
$ git pull https://git.openjdk.org/jdk.git pull/19745/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19745
View PR using the GUI difftool:
$ git pr show -t 19745
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19745.diff
Webrev
Link to Webrev Comment