Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8329335: HttpsURLConnectionTest fails due to network firewall rules #19745

Closed
wants to merge 1 commit into from

Conversation

fguallini
Copy link
Member

@fguallini fguallini commented Jun 17, 2024

Since HttpsURLConnectionTest attempts to reach external servers, it can fail if run on hosts without outbound traffic allowed. Therefore, it should not be executed in CI pipelines but rather manually on a host with no firewall rules preventing egress traffic.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8329335: HttpsURLConnectionTest fails due to network firewall rules (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19745/head:pull/19745
$ git checkout pull/19745

Update a local copy of the PR:
$ git checkout pull/19745
$ git pull https://git.openjdk.org/jdk.git pull/19745/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19745

View PR using the GUI difftool:
$ git pr show -t 19745

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19745.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 17, 2024

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 17, 2024

@fguallini The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jun 17, 2024
@fguallini fguallini changed the title test should be run manually to avoid proxy problems 8329335: HttpsURLConnectionTest fails due to network firewall rules Jun 17, 2024
@fguallini fguallini changed the title 8329335: HttpsURLConnectionTest fails due to network firewall rules 832933: HttpsURLConnectionTest fails due to network firewall rules Jun 17, 2024
@fguallini fguallini changed the title 832933: HttpsURLConnectionTest fails due to network firewall rules 8329335: HttpsURLConnectionTest fails due to network firewall rules Jun 17, 2024
@fguallini fguallini marked this pull request as ready for review June 17, 2024 14:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 17, 2024

Webrevs

@mahendrachhipa
Copy link
Member

Hi @fguallini , what if NAT Gateway of CI machines VCN is configured to allow one way initiation traffic to specific external server. Then this change is not required.

@fguallini fguallini closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants