Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned #19978

Closed
wants to merge 3 commits into from

Conversation

liach
Copy link
Member

@liach liach commented Jul 1, 2024

Clarify that only Class is returned for core reflection implementation, and the return type is Type to support other implementations, such as ones modeling unloaded or remote types.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned (Enhancement - P4)
  • JDK-8335473: Clarify in ParameterizedType.getRawType() doc that only Class is returned (CSR) (Withdrawn)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19978/head:pull/19978
$ git checkout pull/19978

Update a local copy of the PR:
$ git checkout pull/19978
$ git pull https://git.openjdk.org/jdk.git pull/19978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19978

View PR using the GUI difftool:
$ git pr show -t 19978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19978.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

…s is returned
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2024

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8250659: Clarify in ParameterizedType.getRawType() doc that only Class is returned

Reviewed-by: darcy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 89 new commits pushed to the master branch:

  • 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
  • 4ce19ca: 8343190: GHA: Try building JTReg several times
  • 7c800e6: 8343026: JFR: Index into fields in the topFrame
  • d8b3685: 8342607: Enhance register printing on x86_64 platforms
  • d8430ef: 8339573: Update CodeCacheSegmentSize and CodeEntryAlignment for ARM
  • 6332e25: 8343183: [s390x]: Problemlist runtime/Monitor/SyncOnValueBasedClassTest.java Failure
  • 79a07ad: 8343149: Cleanup os::print_tos_pc on AIX
  • beff8bf: 8342823: Ubsan: ciEnv.cpp:1614:65: runtime error: member call on null pointer of type 'struct CompileTask'
  • e389f82: 8343137: C2: VerifyLoopOptimizations fails with "Was reachable in only one"
  • 0abfa3b: 8304824: NMT should not use ThreadCritical
  • ... and 79 more: https://git.openjdk.org/jdk/compare/af5e53241b5f05ef56a437b66b2ad8c5eea5462c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@liach The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2024

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Jul 29, 2024

Keep-alive.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 27, 2024

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2024

@liach This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 24, 2024
@liach
Copy link
Member Author

liach commented Sep 24, 2024

/open

@openjdk openjdk bot reopened this Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@liach This pull request is now open

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 22, 2024

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@liach
Copy link
Member Author

liach commented Oct 22, 2024

/csr unneeded

@openjdk openjdk bot removed the csr Pull request needs approved CSR before integration label Oct 22, 2024
@openjdk
Copy link

openjdk bot commented Oct 22, 2024

@liach determined that a CSR request is not needed for this pull request.

Copy link
Member

@jddarcy jddarcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 29, 2024
@liach
Copy link
Member Author

liach commented Oct 30, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2024

Going to push as commit 158ae51.
Since your change was applied there have been 95 commits pushed to the master branch:

  • b6f745d: 8342489: compiler/c2/irTests/TestVectorizationMismatchedAccess.java fails on big-endian platforms
  • bd79594: 8343037: Missing @SInCE tag on JColorChooser.showDialog overload
  • ceaa71e: 8342576: [macos] AppContentTest still fails after JDK-8341443 for same reason on older macOS versions
  • 40f3d50: 8343211: Compile error: redefinition of 'Assembler::evmovdquw(XMMRegister,KRegister,XMMRegister,bool,int)'
  • 60364ef: 8341273: JVMTI is not properly hiding some continuation related methods
  • 520ddac: 8331861: [PPC64] Implement load / store assembler functions which take an Address object
  • 9cfb0f7: 8341527: AVX-512 intrinsic for SHA3
  • 4ce19ca: 8343190: GHA: Try building JTReg several times
  • 7c800e6: 8343026: JFR: Index into fields in the topFrame
  • d8b3685: 8342607: Enhance register printing on x86_64 platforms
  • ... and 85 more: https://git.openjdk.org/jdk/compare/af5e53241b5f05ef56a437b66b2ad8c5eea5462c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2024
@openjdk openjdk bot closed this Oct 30, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2024
@openjdk
Copy link

openjdk bot commented Oct 30, 2024

@liach Pushed as commit 158ae51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants