8334772: Change Class::protectionDomain and signers to explicit fields #20221
+55
−120
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this change that moves
Class.protectionDomain
andsigners
to explicit fields.Related native methods in
Class
andAccessController::getProtectionDomain
are converted to pure Java. These fields are still set and used by hotspot. Also fixes the incorrectprotectiondomain_signature
invmSymbols
, which is actually an array descriptor.Note that these new fields are not filtered: filtering in early bootstrap requires other unrelated adjustments as we can't even use hashCode on String, and filtering is not proper encapsulation either.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20221/head:pull/20221
$ git checkout pull/20221
Update a local copy of the PR:
$ git checkout pull/20221
$ git pull https://git.openjdk.org/jdk.git pull/20221/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20221
View PR using the GUI difftool:
$ git pr show -t 20221
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20221.diff
Webrev
Link to Webrev Comment