Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8337274: Remove repeated 'the' in StyleSheet.create{Small,Large}AttributeSet #20352

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Jul 26, 2024

A trivial fix which removes the repeated word ‘the’ from the parameter description for StyleSheet.create{Small,Large}AttributeSet methods. These methods are public API.

Additionally, I dropped repeated ‘then’ from the description of a private method.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337274: Remove repeated 'the' in StyleSheet.create{Small,Large}AttributeSet (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20352/head:pull/20352
$ git checkout pull/20352

Update a local copy of the PR:
$ git checkout pull/20352
$ git pull https://git.openjdk.org/jdk.git pull/20352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20352

View PR using the GUI difftool:
$ git pr show -t 20352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20352.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2024

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337274: Remove repeated 'the' in StyleSheet.create{Small,Large}AttributeSet

Reviewed-by: achung, honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 2fbdbac: 8337245: Fix wrong comment of StringConcatHelper
  • 034297a: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • abc4ca5: 8330427: Obsolete -XX:+PreserveAllAnnotations
  • 0c3720b: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F
  • 4f194f1: 8337241: Shenandoah: Normalize include guards
  • f35af71: 8334315: Shenandoah: reduce GC logging noise
  • 4bcb8f0: 8337243: Fix more -Wzero-as-null-pointer-constant warnings in compiler code
  • 3abe8a6: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2024
@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2024

Webrevs

Copy link
Contributor

@alisenchung alisenchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2024
Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not spec-significant

@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

Going to push as commit 066db6e.
Since your change was applied there have been 66 commits pushed to the master branch:

  • 328a053: 8335059: Consider renaming ClassLoaderData::keep_alive
  • a89b525: 8337721: G1: Remove unused G1CollectedHeap::young_collection_verify_type
  • dc35f3e: 8337062: x86_64: Unordered add/mul reduction support for vector api
  • 21e86d1: 8334405: java/nio/channels/Selector/SelectWithConsumer.java#id0 failed in testWakeupDuringSelect
  • f1fa64b: 4966250: SSLSessionContext.setSessionTimeout() documentation could be updated
  • 9fe6e23: 8335638: Calling VarHandle.{access-mode} methods reflectively throws wrong exception
  • 27af80e: 8324260: java/foreign/TestStubAllocFailure.java run timeout with -Xcomp
  • 022899a: 8337641: G1: Remove unused G1CollectedHeap::alloc_highest_free_region
  • c6f0a35: 8333317: Test sun/security/pkcs11/sslecc/ClientJSSEServerJSSE.java failed with: Invalid ECDH ServerKeyExchange signature
  • f174bbd: 8337473: Remove sun/management/jdp tests from ProblemList on Linux-aarch64, MacOSX
  • ... and 56 more: https://git.openjdk.org/jdk/compare/5ff7c57f9ff5428ef3d2aedd7e860bb1e8ff29ea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2024
@openjdk openjdk bot closed this Aug 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@aivanov-jdk Pushed as commit 066db6e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8337274-stylesheet-the-create branch September 24, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

4 participants