Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338447: Remove InstanceKlass::_is_marked_dependent #20595

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Aug 15, 2024

Please review this trivial change. I ran the SA tests to make sure the is_marked_dependent flag in vmStructs wasn't used there.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8338447: Remove InstanceKlass::_is_marked_dependent (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20595/head:pull/20595
$ git checkout pull/20595

Update a local copy of the PR:
$ git checkout pull/20595
$ git pull https://git.openjdk.org/jdk.git pull/20595/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20595

View PR using the GUI difftool:
$ git pr show -t 20595

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20595.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 15, 2024

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338447: Remove InstanceKlass::_is_marked_dependent

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 15, 2024
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 15, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 15, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what removed the last use of it. But this is fine.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 15, 2024
@coleenp
Copy link
Contributor Author

coleenp commented Aug 15, 2024

It was moved into InstanceKlassFlags::_status field which has atomic setters and getters.

@coleenp
Copy link
Contributor Author

coleenp commented Aug 15, 2024

Can I get a 'trival' once GHA finished?

@shipilev
Copy link
Member

Yes, trivial. Feel free to integrate, once builds clear.

@coleenp
Copy link
Contributor Author

coleenp commented Aug 15, 2024

One looks like it glitched. Thanks Aleksey.
/integrate

@openjdk
Copy link

openjdk bot commented Aug 15, 2024

Going to push as commit 1cd4884.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 52d9d69: 8338331: Fix -Wzero-as-null-pointer-constant warnings from CHECK_0 in jni.cpp
  • ace4965: 8338406: BytecodeHelpers using wrong bootstrap method descriptor for condy
  • 9655082: 8338330: Fix -Wzero-as-null-pointer-constant warnings from THROW_XXX_0
  • f308b2d: 8336915: Shenandoah: Remove unused ShenandoahVerifier::verify_after_evacuation
  • e51e40c: 8336914: Shenandoah: Missing verification steps after JDK-8255765
  • ef54af3: 8338444: Shenandoah: Remove ShenandoahHumongousThreshold tunable
  • 7d1bbff: 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java
  • 6169613: 8336655: java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser received no bytes
  • 3859131: 8338442: AArch64: Clean up IndOffXX type and let legitimize_address() fix out-of-range operands
  • 56dec21: 8338014: Improve usage of @JVMS tags in class file API

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 15, 2024
@openjdk openjdk bot closed this Aug 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 15, 2024
@coleenp coleenp deleted the instanceklass-flag branch August 15, 2024 18:20
@openjdk
Copy link

openjdk bot commented Aug 15, 2024

@coleenp Pushed as commit 1cd4884.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants