-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338447: Remove InstanceKlass::_is_marked_dependent #20595
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what removed the last use of it. But this is fine.
It was moved into InstanceKlassFlags::_status field which has atomic setters and getters. |
Can I get a 'trival' once GHA finished? |
Yes, trivial. Feel free to integrate, once builds clear. |
One looks like it glitched. Thanks Aleksey. |
Going to push as commit 1cd4884.
Your commit was automatically rebased without conflicts. |
Please review this trivial change. I ran the SA tests to make sure the is_marked_dependent flag in vmStructs wasn't used there.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20595/head:pull/20595
$ git checkout pull/20595
Update a local copy of the PR:
$ git checkout pull/20595
$ git pull https://git.openjdk.org/jdk.git pull/20595/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20595
View PR using the GUI difftool:
$ git pr show -t 20595
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20595.diff
Webrev
Link to Webrev Comment