Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341111: open source several AWT tests including menu shortcut tests #21291

Closed
wants to merge 2 commits into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Oct 1, 2024

Open source several AWT tests, mostly related to menu short cuts.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8341111: open source several AWT tests including menu shortcut tests

Issue

  • JDK-8341111: open source several AWT tests including menu shortcut tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21291/head:pull/21291
$ git checkout pull/21291

Update a local copy of the PR:
$ git checkout pull/21291
$ git pull https://git.openjdk.org/jdk.git pull/21291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21291

View PR using the GUI difftool:
$ git pr show -t 21291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21291.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 1, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341111: open source several AWT tests including menu shortcut tests

Reviewed-by: psadhukhan, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 146 new commits pushed to the master branch:

  • 3f420fa: 8341451: Remove C2HandleAnonOMOwnerStub
  • d3139b4: 8341000: Open source some of the AWT Window tests
  • 4ded283: 8338136: Hotspot should support multiple large page sizes on Windows
  • 10402b4: 8341489: ProblemList runtime/cds/appcds/DumpRuntimeClassesTest.java in Xcomp mode
  • 6bc3971: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • e89fd1d: 8341128: open source some 2d graphics tests
  • 6f459af: 8340077: Open source few Checkbox tests - Set2
  • b6e72ff: 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status
  • 013250e: 8340432: Open source some MenuBar tests - Set2
  • de12fc7: 8339684: ResizeObserver callback interrupts smooth scrolling on Chrome
  • ... and 136 more: https://git.openjdk.org/jdk/compare/90c2c0b4ad4ee7d2ea149aea771cf81bd666b1dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8341111 8341111: open source several AWT tests including menu shortcut tests Oct 1, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 1, 2024
@openjdk
Copy link

openjdk bot commented Oct 1, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 1, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 1, 2024

Webrevs

if (e.getSource() == change) {
ms = new MenuShortcut(KeyEvent.VK_C);
mi.setShortcut(ms);
PassFailJFrame.log("Shortcut key set to "+shortcut+"C");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 4, 2024
@prrace
Copy link
Contributor Author

prrace commented Oct 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

Going to push as commit 04c9c5f.
Since your change was applied there have been 156 commits pushed to the master branch:

  • 0dd4997: 8340555: Open source DnD tests - Set4
  • beb2a51: 8341377: Update VMProps.isCDSRuntimeOptionsCompatible to include Parallel and Serial GC
  • 42f3255: 8341053: Two CDS tests fail again with -UseCompressedOops and UseSerialGC/UseParallelGC
  • feb6a83: 8340945: Ubsan: oopStorage.cpp:374:8: runtime error: applying non-zero offset 18446744073709551168 to null pointer
  • db61458: 8341298: Open source more AWT window tests
  • 72ac72f: 8341413: Stop including osThread_os.hpp in the middle of the OSThread class
  • 7fa2f22: 8341127: Extra call to MethodHandle::asType from memory segment var handles fails to inline
  • 1bdd79e: 8341261: Tests assume UnlockExperimentalVMOptions is disabled by default
  • ec020f3: 8340426: ZGC: Move defragment out of the allocation path
  • a63ac5a: 8340792: -XX:+PrintInterpreter: instructions should only be printed if printing all InterpreterCodelets
  • ... and 146 more: https://git.openjdk.org/jdk/compare/90c2c0b4ad4ee7d2ea149aea771cf81bd666b1dc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2024
@openjdk openjdk bot closed this Oct 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@prrace Pushed as commit 04c9c5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants