Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341451: Remove C2HandleAnonOMOwnerStub #21319

Closed
wants to merge 1 commit into from

Conversation

xmas92
Copy link
Member

@xmas92 xmas92 commented Oct 3, 2024

JDK-8319796 has been implemented on all platforms which had previous C2 implementations of LM_LIGHTWEIGHT that made use of C2HandleAnonOMOwnerStub.

The declaration is still left in the shared code, an a couple of platforms have the definitions still lingering. I propose we remove them.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8341451: Remove C2HandleAnonOMOwnerStub (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21319/head:pull/21319
$ git checkout pull/21319

Update a local copy of the PR:
$ git checkout pull/21319
$ git pull https://git.openjdk.org/jdk.git pull/21319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21319

View PR using the GUI difftool:
$ git pr show -t 21319

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21319.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2024

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341451: Remove C2HandleAnonOMOwnerStub

Reviewed-by: fyang, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c6e7e55: 8341091: CDS: Segmented roots array misses roots

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2024
@openjdk
Copy link

openjdk bot commented Oct 3, 2024

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Oct 3, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 3, 2024
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@xmas92
Copy link
Member Author

xmas92 commented Oct 4, 2024

Thanks for the reviews.
/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2024

Going to push as commit 3f420fa.
Since your change was applied there have been 21 commits pushed to the master branch:

  • d3139b4: 8341000: Open source some of the AWT Window tests
  • 4ded283: 8338136: Hotspot should support multiple large page sizes on Windows
  • 10402b4: 8341489: ProblemList runtime/cds/appcds/DumpRuntimeClassesTest.java in Xcomp mode
  • 6bc3971: 8341316: [macos] javax/swing/ProgressMonitor/ProgressMonitorEscapeKeyPress.java fails sometimes in macos
  • e89fd1d: 8341128: open source some 2d graphics tests
  • 6f459af: 8340077: Open source few Checkbox tests - Set2
  • b6e72ff: 8339403: sun.security.ssl.StatusResponseManager.get swallows interrupt status
  • 013250e: 8340432: Open source some MenuBar tests - Set2
  • de12fc7: 8339684: ResizeObserver callback interrupts smooth scrolling on Chrome
  • ebb4759: 8340625: Open source additional Component tests (part 3)
  • ... and 11 more: https://git.openjdk.org/jdk/compare/ff3e849b8a1de3741dcd728636e1a804996f96fe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2024
@openjdk openjdk bot closed this Oct 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2024
@openjdk
Copy link

openjdk bot commented Oct 4, 2024

@xmas92 Pushed as commit 3f420fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants