-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8341451: Remove C2HandleAnonOMOwnerStub #21319
Conversation
👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into |
@xmas92 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks for the reviews. |
Going to push as commit 3f420fa.
Your commit was automatically rebased without conflicts. |
JDK-8319796 has been implemented on all platforms which had previous C2 implementations of LM_LIGHTWEIGHT that made use of C2HandleAnonOMOwnerStub.
The declaration is still left in the shared code, an a couple of platforms have the definitions still lingering. I propose we remove them.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21319/head:pull/21319
$ git checkout pull/21319
Update a local copy of the PR:
$ git checkout pull/21319
$ git pull https://git.openjdk.org/jdk.git pull/21319/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21319
View PR using the GUI difftool:
$ git pr show -t 21319
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21319.diff
Webrev
Link to Webrev Comment