Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8340790: Open source several AWT Dialog tests - Batch 4 #21404

Closed
wants to merge 5 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Oct 8, 2024

Open source these AWT Dialog tests:

java/awt/Dialog/FileDialogGetFileTest.java
java/awt/Dialog/EnabledResetTest.java
java/awt/Dialog/ChoiceModalDialogTest.java
java/awt/Dialog/DialogBackgroundTest.java


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340790: Open source several AWT Dialog tests - Batch 4 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21404/head:pull/21404
$ git checkout pull/21404

Update a local copy of the PR:
$ git checkout pull/21404
$ git pull https://git.openjdk.org/jdk.git pull/21404/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21404

View PR using the GUI difftool:
$ git pr show -t 21404

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21404.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2024

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@TejeshR13 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340790: Open source several AWT Dialog tests - Batch 4

Reviewed-by: honkar, prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
  • 5eae20f: 8323672: Suppress unwanted autoconf added flags in CC and CXX
  • 6ed6dff: 8341871: Disable G1 for unsupported platforms after JDK-8334060
  • 54c9348: 8336103: Clean up confusing Method::is_initializer
  • 2c0c653: 8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java
  • df7d6e0: 8338603: DiagnosticCommandMBean operations should standardize types for parameters
  • c9a536c: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp
  • f4dccfd: 8338596: Clarify handling of restricted and caller-sensitive methods
  • 3b8a2f8: 8337269: G1ConfidencePercent interpreted inconsistently
  • 521effe: 8340189: 8339531 incorrect for Big Endian platforms
  • ... and 11 more: https://git.openjdk.org/jdk/compare/dcac4b0a532f2ca6cb374da7ece331e8266ab351...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Oct 8, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2024

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated changes LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 10, 2024
@TejeshR13 TejeshR13 requested a review from honkar-jdk October 14, 2024 09:08
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 14, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2024
@TejeshR13
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 16, 2024

Going to push as commit 6d7e679.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 86ce19e: 8341142: Maintain a single source file for sun.net.www.protocol.jar.JarFileFactory
  • b9cabbe: 8341997: Tests create files in src tree instead of scratch dir
  • 5eae20f: 8323672: Suppress unwanted autoconf added flags in CC and CXX
  • 6ed6dff: 8341871: Disable G1 for unsupported platforms after JDK-8334060
  • 54c9348: 8336103: Clean up confusing Method::is_initializer
  • 2c0c653: 8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java
  • df7d6e0: 8338603: DiagnosticCommandMBean operations should standardize types for parameters
  • c9a536c: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp
  • f4dccfd: 8338596: Clarify handling of restricted and caller-sensitive methods
  • 3b8a2f8: 8337269: G1ConfidencePercent interpreted inconsistently
  • ... and 12 more: https://git.openjdk.org/jdk/compare/dcac4b0a532f2ca6cb374da7ece331e8266ab351...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 16, 2024
@openjdk openjdk bot closed this Oct 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 16, 2024
@openjdk
Copy link

openjdk bot commented Oct 16, 2024

@TejeshR13 Pushed as commit 6d7e679.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants