Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java #21491

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 14, 2024

Test gc/shenandoah/oom/TestClassLoaderLeak.java often times out on WIndows, we should increase the timeout values to avoid test errors.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21491/head:pull/21491
$ git checkout pull/21491

Update a local copy of the PR:
$ git checkout pull/21491
$ git pull https://git.openjdk.org/jdk.git pull/21491/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21491

View PR using the GUI difftool:
$ git pr show -t 21491

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21491.diff

Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 14, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 3b8a2f8: 8337269: G1ConfidencePercent interpreted inconsistently
  • 521effe: 8340189: 8339531 incorrect for Big Endian platforms
  • e6698f5: 8337851: Some tests have name which confuse jtreg
  • a601cd2: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags
  • bd62644: 8341924: Improve error message with structurally malformed Code array
  • a2c7752: 8317356: Fix missing null checks in the ClassFile API
  • 6071346: 8339879: Open some dialog awt tests
  • a8a8b2d: 8341831: PhaseCFG::insert_anti_dependences asserts with "no loads"
  • 9e262df: 8342002: sun/security/tools/keytool/GenKeyPairSigner.java failed due to missing certificate output
  • f56a154: 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3
  • ... and 1 more: https://git.openjdk.org/jdk/compare/1581508988141bfb420d97759138203f30926b35...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java 8342044: Increase timeout of gc/shenandoah/oom/TestClassLoaderLeak.java Oct 14, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 14, 2024
@openjdk
Copy link

openjdk bot commented Oct 14, 2024

@MBaesken The following labels will be automatically applied to this pull request:

  • hotspot-gc
  • shenandoah

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-gc hotspot-gc-dev@openjdk.org shenandoah shenandoah-dev@openjdk.org labels Oct 14, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 14, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 15, 2024
@MBaesken
Copy link
Member Author

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 15, 2024

Going to push as commit 2c0c653.
Since your change was applied there have been 14 commits pushed to the master branch:

  • df7d6e0: 8338603: DiagnosticCommandMBean operations should standardize types for parameters
  • c9a536c: 8337339: gc/arguments/Test*SizeFlags.java timing out with Xcomp
  • f4dccfd: 8338596: Clarify handling of restricted and caller-sensitive methods
  • 3b8a2f8: 8337269: G1ConfidencePercent interpreted inconsistently
  • 521effe: 8340189: 8339531 incorrect for Big Endian platforms
  • e6698f5: 8337851: Some tests have name which confuse jtreg
  • a601cd2: 8342014: RISC-V: ZStoreBarrierStubC2 clobbers rflags
  • bd62644: 8341924: Improve error message with structurally malformed Code array
  • a2c7752: 8317356: Fix missing null checks in the ClassFile API
  • 6071346: 8339879: Open some dialog awt tests
  • ... and 4 more: https://git.openjdk.org/jdk/compare/1581508988141bfb420d97759138203f30926b35...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 15, 2024
@openjdk openjdk bot closed this Oct 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 15, 2024
@openjdk
Copy link

openjdk bot commented Oct 15, 2024

@MBaesken Pushed as commit 2c0c653.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated shenandoah shenandoah-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

2 participants