-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8342787: Move misplaced TestTemplateAssertionPredicateWithTwoUCTs.java from src to test directory #21629
Conversation
…a from src to test directory
👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into |
@chhagedorn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@chhagedorn The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and trivial.
Not sure whether this ends with a newline or not (I think it does), but thanks for fixing this! |
Thanks @TobiHartmann, @shipilev, and @TheShermanTanker for the quick reviews!
It does, there were two new lines, so I removed one. Github will show a special "no-new-line" icon otherwise :-) |
/integrate |
Going to push as commit 2da7f2b.
Your commit was automatically rebased without conflicts. |
@chhagedorn Pushed as commit 2da7f2b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
For some unknown reason,
TestTemplateAssertionPredicateWithTwoUCTs.java
ended up in the src directory instead of the test directory with JDK-8342287. Maybe a patch application have gone wrong when moving the test to another checked out JDK repository. Anyway, this patch moves it to the correct place.Thanks to @TheShermanTanker for spotting this!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21629/head:pull/21629
$ git checkout pull/21629
Update a local copy of the PR:
$ git checkout pull/21629
$ git pull https://git.openjdk.org/jdk.git pull/21629/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21629
View PR using the GUI difftool:
$ git pr show -t 21629
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21629.diff
Webrev
Link to Webrev Comment