Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values #21734

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Oct 28, 2024

Hi all,
We have observed ThreadsListHandle.sanity_vm failed with unequal ThreadList values several times on linux-x64 and linux-aarch64, by jdk17u/jdk21u/jdk24 etc.
Before the root cause of the test failure has been fixed, should we disable the unstable check of ThreadsListHandle.sanity_vm ThreadList values, to make less of CI noisy.

Additional testing:

  • release build and run the gtest/GTestWrapper.java on linux-x64
  • fastdebug build and run the gtest/GTestWrapper.java on linux-x64
  • slowdebug build and run the gtest/GTestWrapper.java on linux-x64

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21734/head:pull/21734
$ git checkout pull/21734

Update a local copy of the PR:
$ git checkout pull/21734
$ git pull https://git.openjdk.org/jdk.git pull/21734/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21734

View PR using the GUI difftool:
$ git pr show -t 21734

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21734.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

…List values
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 345 new commits pushed to the master branch:

  • a47d9ba: 8344349: Problemlist jdk/jfr/jvm/TestVirtualThreadExclusion.java before JDK-8344199 resolved
  • 80e37a9: 8344265: RISC-V: Remove unused function get_previous_sp_entry
  • e1c4b49: 8343237: Improve the copying of the available set of Currencies
  • 41a627b: 8343876: Enhancements to jpackage test lib
  • aa10ec7: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window
  • fec0d1c: 8343777: Add since checker tests to Internationalisation modules
  • d0b770c: 8344289: SM cleanup in jdk.internal.util
  • a91d4c0: 8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration
  • d2e4b51: 8344186: Cleanup sun.net.www.MimeTable after JEP 486 integration
  • da40388: 8344315: Clean up sun.net.www.protocol.jrt.JavaRuntimeURLConnection after JEP 486 integration
  • ... and 335 more: https://git.openjdk.org/jdk/compare/0e3fc93dfb14378a848571a6b83282c0c73e690f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 28, 2024
@openjdk
Copy link

openjdk bot commented Oct 28, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Oct 28, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2024

Webrevs

@sendaoYan
Copy link
Member Author

Hi, can anyone take look this PR.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The util vs until typo needs fixing everywhere.

I guess this is okay - similar to ProblemListing. For the record we don't see any failures of this that I could find.

@sendaoYan
Copy link
Member Author

The util vs until typo needs fixing everywhere.

Thanks for the review, the typo bug has been fixed.

I guess this is okay - similar to ProblemListing. For the record we don't see any failures of this that I could find.

Maybe we should add problemlist label for JDK-8315141 after this PR integrated.

@dholmes-ora
Copy link
Member

I guess this is okay - similar to ProblemListing. For the record we don't see any failures of this that I could find.

Maybe we should add problemlist label for JDK-8315141 after this PR integrated.

A reasonable suggestion, but as that isn't the intended use of the label* it probably should not be done.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2024
@sendaoYan
Copy link
Member Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

Going to push as commit 59fcfae.
Since your change was applied there have been 393 commits pushed to the master branch:

  • 1717946: 8344302: G1: Refactor G1CMTask::do_marking_step to use smaller wrapper methods
  • fea5f2b: 8344415: Restruct jpackage utility classes
  • a28e4d8: 8342299: Document that jpackage includes (possibly old) VC Redistributable MSVCP140.dll from JDK
  • 0714114: 8344322: Improve capabilities of jpackage test lib to validate error output of jpackage
  • 41436bb: 8336087: Doccheck: the jpackage command page doesn't show the correct command-line options
  • cc8bd63: 8344036: Tests tools/jlink/runtimeImage fail on AIX after JDK-8311302
  • 2359736: 8344534: Remove leftover import of java.security.AccessControlContext in JavaLangAccess
  • 0d66689: 8344393: RISC-V: Remove option UseRVVForBigIntegerShiftIntrinsics
  • 7540fa2: 8343884: [s390x] Disallow OptoScheduling
  • 9d60300: 8344199: Incorrect excluded field value set by getEventWriter intrinsic
  • ... and 383 more: https://git.openjdk.org/jdk/compare/0e3fc93dfb14378a848571a6b83282c0c73e690f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 19, 2024
@openjdk openjdk bot closed this Nov 19, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 19, 2024
@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@sendaoYan Pushed as commit 59fcfae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8343129 branch November 19, 2024 15:18
@sendaoYan
Copy link
Member Author

The Problemlist label of JDK-8315141 has been deleted.

@sendaoYan
Copy link
Member Author

GHA report 2 failures

  1. macos-aarch64 build debug job at install toolchain and dependencies stage fails invalid developer directory seems like environmental issue or infra issue, it's unreleated to this issue.
  2. macos-aarch64 build release job at install toolchain and dependencies stage fails invalid developer directory seems like environmental issue or infra issue, it's unreleated to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants