-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343129: Disable unstable check of ThreadsListHandle.sanity_vm ThreadList values #21734
Conversation
…List values
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 345 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
Hi, can anyone take look this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The util
vs until
typo needs fixing everywhere.
I guess this is okay - similar to ProblemListing. For the record we don't see any failures of this that I could find.
Thanks for the review, the typo bug has been fixed.
Maybe we should add |
A reasonable suggestion, but as that isn't the intended use of the label* it probably should not be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
Thanks for the review. /integrate |
Going to push as commit 59fcfae.
Your commit was automatically rebased without conflicts. |
@sendaoYan Pushed as commit 59fcfae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The Problemlist label of JDK-8315141 has been deleted. |
GHA report 2 failures
|
Hi all,
We have observed
ThreadsListHandle.sanity_vm failed with unequal ThreadList values
several times on linux-x64 and linux-aarch64, by jdk17u/jdk21u/jdk24 etc.Before the root cause of the test failure has been fixed, should we disable the unstable check of ThreadsListHandle.sanity_vm ThreadList values, to make less of CI noisy.
Additional testing:
gtest/GTestWrapper.java
on linux-x64gtest/GTestWrapper.java
on linux-x64gtest/GTestWrapper.java
on linux-x64Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21734/head:pull/21734
$ git checkout pull/21734
Update a local copy of the PR:
$ git checkout pull/21734
$ git pull https://git.openjdk.org/jdk.git pull/21734/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 21734
View PR using the GUI difftool:
$ git pr show -t 21734
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21734.diff
Using Webrev
Link to Webrev Comment