8343298: Improve stability of runtime/cds/DeterministicDump.java test

[tschatzl]

Hi all,

please review this change to make runtime/cds/DeterministicDump.java more reliable in presence of GC changes (which https://bugs.openjdk.org/browse/JDK-8295269 stumbled over).

This includes some change to strip the gc age from the dumped objects, but mainly trying to fix heap sizes etc so that GCs are executed consistently (i.e. not at all) in this test.

Testing: tier5, running the test a few thousand times

Thanks,
Thomas

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343298: Improve stability of runtime/cds/DeterministicDump.java test (Enhancement - P4)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21871/head:pull/21871
$ git checkout pull/21871

Update a local copy of the PR:
$ git checkout pull/21871
$ git pull https://git.openjdk.org/jdk.git pull/21871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21871

View PR using the GUI difftool:
$ git pr show -t 21871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21871.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343298: Improve stability of runtime/cds/DeterministicDump.java test

Reviewed-by: shade, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

• 20f3aaf: 8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999
• 67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
• 714472d: 8341798: Fix ExceptionOccurred in jdk.jdwp.agent
• 825ceb1: 8341796: Fix ExceptionOccurred in jdk.hotspot.agent
• 8b47497: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
• 0668e18: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
• 774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
• 1cc3586: 8343551: Missing copyright header update in Charset-X-Coder.java.template
• 1c44834: 8333582: Update CLDR to Version 46.0
• 23fa1a3: 8343484: Remove unnecessary @SuppressWarnings annotations (nio)
• ... and 14 more: https://git.openjdk.org/jdk/compare/e7f0bf11ff0e89b6b156d5e88ca3771c706aa46a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a1f1905d)
• 00: Full (46f59174)

[shipilev]

Generally looks okay, but I have a few questions:

[iklam]

LGTM

[tschatzl]

Thanks @iklam @shipilev for your reviews

/integrate

[openjdk]

Going to push as commit abf2dc7.
Since your change was applied there have been 27 commits pushed to the master branch:

• dafa2e5: 8343124: Tests fails with java.lang.IllegalAccessException: class com.sun.javatest.regtest.agent.MainWrapper$MainTask cannot access
• 0f7dd98: 8251926: PPC: Remove an unused variable in assembler_ppc.cpp
• cd91a44: 8343549: SeededSecureRandomTest needn't be in a package
• 20f3aaf: 8343471: RISC-V: compiler/cpuflags/TestAESIntrinsicsOnUnsupportedConfig.java fails after JDK-8334999
• 67907d5: 8343500: Optimize ArrayClassDescImpl computeDescriptor
• 714472d: 8341798: Fix ExceptionOccurred in jdk.jdwp.agent
• 825ceb1: 8341796: Fix ExceptionOccurred in jdk.hotspot.agent
• 8b47497: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server
• 0668e18: 8343234: (bf) Move java/nio/Buffer/LimitDirectMemory.java from ProblemList.txt to ProblemList-Virtual.txt
• 774de27: 8343497: Missing DEF_STATIC_JNI_OnLoad in libjimage and libsaproc native libraries
• ... and 17 more: https://git.openjdk.org/jdk/compare/e7f0bf11ff0e89b6b156d5e88ca3771c706aa46a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tschatzl Pushed as commit abf2dc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.