8211033: Clean up the processing -classpath argument not to set LM_CLASS

[jaikiran]

Can I please get a review of this change which addresses https://bugs.openjdk.org/browse/JDK-8211033?

As noted in that issue, this is a clean up of the code which determines the "mode" through with the java application is being launched. In its current form the presence of --classpath (or its equivalent arguments) was unnecessary updating the mode to LM_CLASS. The commit in this PR removes that part to allow for the mode to be detected based merely on the presence (or absence) of -m, -jar, --source options. If neither is specified, the file extension is checked to determine the launch mode.

Given the nature of this clean up, no new tests have been introduced. Existing tests in tier1, tier2, tier3 continue to pass with this change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8211033: Clean up the processing -classpath argument not to set LM_CLASS (Enhancement - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21971/head:pull/21971
$ git checkout pull/21971

Update a local copy of the PR:
$ git checkout pull/21971
$ git pull https://git.openjdk.org/jdk.git pull/21971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21971

View PR using the GUI difftool:
$ git pr show -t 21971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21971.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8211033: Clean up the processing -classpath argument not to set LM_CLASS

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 0c281ac: 8343754: Problemlist jdk/jfr/event/oldobject/TestShenandoah.java after JDK-8279016
• 2e58ede: 8341399: Add since checker tests to the langtools modules
• c7f071c: 8343189: [REDO] JDK-8295269 G1: Improve slow startup due to predictor initialization
• a9e53bb: 8343783: Improve asserts in concurrentHashTable.inline.hpp
• bf5c3ce: 8272780: ServerNotifForwarder.removeNotificationListener() incorrect exception handling
• a10b1cc: 8340532: C2: assert(is_OuterStripMinedLoop()) failed: invalid node class: IfTrue
• d0077ee: 8343771: Some FFM benchmarks are broken

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (11ae2138)

[AlanBateman]

On the surface this looks okay but just to double check: this has no impact on java -cp <classpath> -jar app.jar. The class path in that case is app.jar, the class path specified to -cp is ignored.

[jaikiran]

On the surface this looks okay but just to double check: this has no impact on java -cp <classpath> -jar app.jar. The class path in that case is app.jar, the class path specified to -cp is ignored.

That's right - the launcher explicitly overrides the classpath in that case here https://github.com/openjdk/jdk/blob/master/src/java.base/share/native/libjli/java.c#L313:

/* Override class path if -jar flag was specified */
if (mode == LM_JAR) {
    SetClassPath(what);     /* Override class path */
}

[jaikiran]

Thank you Alan for the review.

[jaikiran]

/integrate

[openjdk]

Going to push as commit ca69a53.
Since your change was applied there have been 23 commits pushed to the master branch:

• 7b0f273: 8343894: ProblemList javax/management/remote/mandatory/notif/EmptyDomainNotificationTest.java
• 74ae3c6: 8343650: Reuse StringLatin1::putCharsAt and StringUTF16::putCharsAt
• 423e8e0: 8339162: [REDO] JDK-8338440 Parallel: Improve fragmentation mitigation in Full GC
• f400896: 8342442: Static ACVP sample tests
• 325a2c3: 8343848: Fix typo of property name in TestOAEPPadding after 8341927
• 2614c99: 8343793: Test java/foreign/TestMemorySession.java is timing out
• 8a69893: 8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double
• 52c0b09: 8277240: java/awt/Graphics2D/ScaledTransform/ScaledTransform.java dialog does not get disposed
• 0329855: 8343804: Show the default time zone with -XshowSettings option
• 44ec501: 8305895: Implement JEP 450: Compact Object Headers (Experimental)
• ... and 13 more: https://git.openjdk.org/jdk/compare/068f4ce8bc0fb43417c6493597160b49554221d3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit ca69a53.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.