8341793: Fix ExceptionOccurred in jdk.accessibility

[bourgesl]

Use ExceptionCheck instead

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8341793: Fix ExceptionOccurred in jdk.accessibility (Sub-task - P4)

Reviewers

• Alexey Ushakov (@avu - Committer) Review applies to 18947212
• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/21979/head:pull/21979
$ git checkout pull/21979

Update a local copy of the PR:
$ git checkout pull/21979
$ git pull https://git.openjdk.org/jdk.git pull/21979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 21979

View PR using the GUI difftool:
$ git pr show -t 21979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/21979.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lbourges! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@bourgesl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8341793: Fix ExceptionOccurred in jdk.accessibility

Reviewed-by: prr, avu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 222 new commits pushed to the master branch:

• 69c9f25: 8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2
• 3328b4e: 8343700: ceil_log2 should not loop endlessly
• 6a5256e: 8344149: Remove usage of Security Manager from java.rmi
• 0b1f571: 8253440: serviceability/sa/TestJhsdbJstackLineNumbers.java failed with "Didn't find enough line numbers"
• 93e889b: 8342449: reimplement: JDK-8327114 Attach in Linux may have wrong behavior when pid == ns_pid
• bb7a840: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS
• 087a07b: 8343479: Remove unnecessary @SuppressWarnings annotations (hotspot)
• 02ec8ca: 8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay
• 47ebf8d: 8342098: Write a test to compare the images
• 78602be: 8344024: Unnecessary Hashtable usage in RSAPSSSignature.DIGEST_LENGTHS
• ... and 212 more: https://git.openjdk.org/jdk/compare/7d6a2f3740bf42652bdf05bb922d1f2b2ae60d6a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@bourgesl The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 04: Full - Incremental (9a006bb6)
• 03: Full - Incremental (d7544973)
• 02: Full - Incremental (81b2efa4)
• 01: Full - Incremental (b4fc07a0)
• 00: Full (18947212)

[avu]

LGTM

[bourgesl]

I will check windows build failure:
https://github.com/bourgesl/jdk-official/actions/runs/11882209379/job/33107442693#step:10:1

[prrace]

I will check windows build failure: https://github.com/bourgesl/jdk-official/actions/runs/11882209379/job/33107442693#step:10:1

D'oh. I missed that. this is C++. But you added the env arg.
Are you not building this locally ? Seems not.
If you have a windows-specific fix it is a good idea to have windows available.

[prrace]

you need to remove the env arg.

[bourgesl]

I will check windows build failure:
https://github.com/bourgesl/jdk-official/actions/runs/11882209379/job/33107442693#step:10:1

Thanks, I am using my macbook pro but can use another laptop to build & run windows ...
Will check on this dell 7670 windows 10.

[bourgesl]

@prrace build is ok. Approved ?

[bourgesl]

/integrate

[openjdk]

Going to push as commit aac1f9a.
Since your change was applied there have been 223 commits pushed to the master branch:

• cd45ba3: 8342041: Test gc/shenandoah/oom/TestClassLoaderLeak.java slow on Windows after JDK-8340490
• 69c9f25: 8344061: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 2
• 3328b4e: 8343700: ceil_log2 should not loop endlessly
• 6a5256e: 8344149: Remove usage of Security Manager from java.rmi
• 0b1f571: 8253440: serviceability/sa/TestJhsdbJstackLineNumbers.java failed with "Didn't find enough line numbers"
• 93e889b: 8342449: reimplement: JDK-8327114 Attach in Linux may have wrong behavior when pid == ns_pid
• bb7a840: 8342541: Exclude List/KeyEventsTest/KeyEventsTest.java from running on macOS
• 087a07b: 8343479: Remove unnecessary @SuppressWarnings annotations (hotspot)
• 02ec8ca: 8342508: Use latch in BasicMenuUI/bug4983388.java instead of delay
• 47ebf8d: 8342098: Write a test to compare the images
• ... and 213 more: https://git.openjdk.org/jdk/compare/7d6a2f3740bf42652bdf05bb922d1f2b2ae60d6a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bourgesl Pushed as commit aac1f9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.