-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main #22026
Conversation
👋 Welcome back tr! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@TejeshR13 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
On macos I see no scroll buttons so the test instructions are slightly inaccurate. Are there any plans to fix the issue of mouse cursor changing when dragging onto different components? What should be expected behavior here? What happens on native applications? |
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
Webrevs
|
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still consider the minor suggestions remaining, but the test works and it's instructions look good.
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
test/jdk/java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest.java
Outdated
Show resolved
Hide resolved
Tested on win11 system and it didn't work as expected while dragging mouse from text_box to any other component. Mouse cursor changed to default Arrow style as soon as mouse is dragged out of text box. No issues on Ubuntu_22.04 system. |
Yes, looks like its not consistent. I see the issue happens when we are using JPassFailJFrame, without it there is no issue. Will get back on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tried running on win11 after Abhishek's find. Looks like he's right. Looking at your changes, I don't see a setCursor
anywhere, so it probably has something to do with PassFailJFrame
. The only other difference in your changes I see is the StringBuilder
, but that seems unlikely to be the cause.
@TejeshR13 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@TejeshR13 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
The test is supposed to be problem listed on macos & Linux but the Problem list points to the .java file instead of the .html file.
Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which would automatically resolve the issue.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22026/head:pull/22026
$ git checkout pull/22026
Update a local copy of the PR:
$ git checkout pull/22026
$ git pull https://git.openjdk.org/jdk.git pull/22026/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22026
View PR using the GUI difftool:
$ git pr show -t 22026
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22026.diff
Using Webrev
Link to Webrev Comment