Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main #22026

Closed
wants to merge 5 commits into from

Conversation

TejeshR13
Copy link
Contributor

@TejeshR13 TejeshR13 commented Nov 12, 2024

The test is supposed to be problem listed on macos & Linux but the Problem list points to the .java file instead of the .html file.
Hence converting java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main which would automatically resolve the issue.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22026/head:pull/22026
$ git checkout pull/22026

Update a local copy of the PR:
$ git checkout pull/22026
$ git pull https://git.openjdk.org/jdk.git pull/22026/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22026

View PR using the GUI difftool:
$ git pr show -t 22026

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22026.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2024

👋 Welcome back tr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Nov 12, 2024

@TejeshR13 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 12, 2024
@alisenchung
Copy link
Contributor

On macos I see no scroll buttons so the test instructions are slightly inaccurate. Are there any plans to fix the issue of mouse cursor changing when dragging onto different components? What should be expected behavior here? What happens on native applications?

@TejeshR13 TejeshR13 changed the title Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main 8343977: Convert java/awt/TextArea/TextAreaCursorTest/HoveringAndDraggingTest to main Nov 15, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2024

Webrevs

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still consider the minor suggestions remaining, but the test works and it's instructions look good.

@kumarabhi006
Copy link
Contributor

Tested on win11 system and it didn't work as expected while dragging mouse from text_box to any other component. Mouse cursor changed to default Arrow style as soon as mouse is dragged out of text box.
However the applet version of test is working as expected on windows.

No issues on Ubuntu_22.04 system.

@TejeshR13
Copy link
Contributor Author

Tested on win11 system and it didn't work as expected while dragging mouse from text_box to any other component. Mouse cursor changed to default Arrow style as soon as mouse is dragged out of text box. However the applet version of test is working as expected on windows.

No issues on Ubuntu_22.04 system.

Yes, looks like its not consistent. I see the issue happens when we are using JPassFailJFrame, without it there is no issue. Will get back on this.

Copy link
Contributor

@DamonGuy DamonGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried running on win11 after Abhishek's find. Looks like he's right. Looking at your changes, I don't see a setCursor anywhere, so it probably has something to do with PassFailJFrame. The only other difference in your changes I see is the StringBuilder, but that seems unlikely to be the cause.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2024

@TejeshR13 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2025

@TejeshR13 This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

None yet

5 participants