-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8343219 : Manual clientlibs test failures after SM removal #22054
Conversation
👋 Welcome back honkar! A progress list of the required criteria for merging this PR into |
@honkar-jdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@honkar-jdk The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing but deletions !
/integrate |
Going to push as commit 1eb38c8.
Your commit was automatically rebased without conflicts. |
@honkar-jdk Pushed as commit 1eb38c8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Following tests are deleted as part of post-SM Removal (JEP 486) cleanup.
java/awt/print/PrinterJob/CheckPrivilege.java - Deleted. The test is to verify if printing code does necessary doPrivilege() calls when SM is installed.
javax/print/PrintSE/PrintSE.sh - Deleted. Test checks if queuePrintJob has sufficient permissions for printing when SM is installed. No longer holds value without SM.
java/awt/print/PrinterJob/SecurityDialogTest.java - Deleted. This test specifically tests if "Print to file" option is disabled if reading/writing files is not allowed when Security Manager is present. Since this case is no longer true after SM removal the test has been deleted.
java/awt/Dialog/PrintToFileTest/PrintToFileGranted.java - Deleted. This specifically tests if "Print to file" option is enabled when read/write permissions are granted with SM. Since this is no longer the case after SM removal the test has been deleted.
java/awt/Dialog/PrintToFileTest/PrintToFileRevoked.java - Deleted. This is similar to the above test and checks if "Print to file" option is disabled when write permission is revoked with SM.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22054/head:pull/22054
$ git checkout pull/22054
Update a local copy of the PR:
$ git checkout pull/22054
$ git pull https://git.openjdk.org/jdk.git pull/22054/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22054
View PR using the GUI difftool:
$ git pr show -t 22054
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22054.diff
Using Webrev
Link to Webrev Comment