8293040: Argfile documentation for java launcher tool is confusing regarding usage of wildcards #22208
Conversation
…garding usage of wildcards Improve the documentation covering the usage of wildcards in `java `'s argfiles.
|
👋 Welcome back cstein! A progress list of the required criteria for merging this PR into |
|
@sormuras This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@sormuras To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label core-libs |
|
@sormuras |
|
/integrate |
|
Going to push as commit 5cb0d43.
Your commit was automatically rebased without conflicts. |
openjdk
bot
removed
ready
|
Hello Christian, one part of the confusion noted in that linked issue https://bugs.openjdk.org/browse/JDK-8293040 is:
is noted in the section which describes the contents of the argument files for I see that the changes in this PR didn't address that sentence. Was that intentional? |
|
No, that was an oversight. Good catch! I will remove that sentence (second last bullet point) in favor of the augmented one (third bullet point) of this PR. |
| file. That means, an asterisk `*` is passed on as-is to the starting VM. | ||
| For example `*.java` stays `*.java` and is not expanded to `Foo.java`, | ||
| `Bar.java`, etc. like on some command line shell. | ||
|
|
There was a problem hiding this comment.
This expansion now seems to be in conflict with the later statement:
Wildcards (*) aren't allowed in these lists (such as specifying *.java).
?? To be honest I'm not sure what that later statement is actually trying to say.
There was a problem hiding this comment.
Never mind I see now this was already flagged.
There was a problem hiding this comment.
I think that sentence was trying to convey that the "wildcard literal * will be treated literally and the launcher will not attempt to expand it". I think this sentence can be removed altogether, given that this semantic is already explained a few sentences above by the change in this PR.
Filed #22236 to removed the sentence. |
Please review this improvement to the manual page covering the usage of wildcards in
java's argfiles.Progress
Issue
Reviewers
Reviewers without OpenJDK IDs
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22208/head:pull/22208$ git checkout pull/22208Update a local copy of the PR:
$ git checkout pull/22208$ git pull https://git.openjdk.org/jdk.git pull/22208/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22208View PR using the GUI difftool:
$ git pr show -t 22208Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22208.diff
Using Webrev
Link to Webrev Comment