Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344853: Parallel: Improve comments in psParallelCompact #22318

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 22, 2024

Trivial revising some existing comments and adding some comments. No real code change other than a renaming.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344853: Parallel: Improve comments in psParallelCompact (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22318/head:pull/22318
$ git checkout pull/22318

Update a local copy of the PR:
$ git checkout pull/22318
$ git pull https://git.openjdk.org/jdk.git pull/22318/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22318

View PR using the GUI difftool:
$ git pr show -t 22318

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22318.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344853: Parallel: Improve comments in psParallelCompact

Reviewed-by: sjohanss, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 43 new commits pushed to the master branch:

  • 4110d39: 8344865: SM cleanup in sun/reflect/annotation
  • 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
  • e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
  • cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
  • c6b14c6: 8344841: ClassPrinter prints confusing value for null
  • ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
  • 965aace: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
  • 811d08c: 8340010: Fix vectorization tests with compact headers
  • 519bb26: 8344217: Remove calls to SecurityManager and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration
  • d112f35: 8344855: Remove calls to SecurityManager and doPrivileged in HTTP related implementation classes in the sun.net and sun.net.www.http packages after JEP 486 integration
  • ... and 33 more: https://git.openjdk.org/jdk/compare/a07b72bfcfa603453ea042e89adeb9dcec8bf63a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8344853 8344853: Parallel: Improve comments in psParallelCompact Nov 22, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024
Copy link
Contributor

@zhengyu123 zhengyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 26, 2024

Going to push as commit 9793e73.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 57d35f9: 8344382: RISC-V: CASandCAEwithNegExpected fails with Zacas
  • 0105203: 8337660: C2: basic blocks with only BoxLock nodes are wrongly treated as empty
  • 4e68d66: 8344954: Linker tests fails on BE platforms after JDK-8340205
  • ca81ab5: 8344994: Remove most uses of RuntimePermission checks in java.desktop
  • 43603ac: 8344894: Obsolete reference to checking permissions in java.awt.Composite
  • 4d4cef8: 8344337: SecurityManager cleanup in java.prefs module
  • 1c7f34d: 8345000: Remove last mentions of sun.awt.AWTPermissions
  • 5e0d42b: 8344916: RISC-V: Misaligned access in array fill stub
  • 3326874: 8344857: Remove calls to SecurityManager and doPrivileged in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration
  • 48e3b65: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
  • ... and 52 more: https://git.openjdk.org/jdk/compare/a07b72bfcfa603453ea042e89adeb9dcec8bf63a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 26, 2024
@openjdk openjdk bot closed this Nov 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 26, 2024
@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@albertnetymk Pushed as commit 9793e73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch November 26, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants