Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources #22336

Closed
wants to merge 2 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 22, 2024

Cleanup of doPrivileged in:
sun.util.calendar
sun.util.local/provider
sun.util.cldr
sun.util.resources


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22336/head:pull/22336
$ git checkout pull/22336

Update a local copy of the PR:
$ git checkout pull/22336
$ git pull https://git.openjdk.org/jdk.git pull/22336/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22336

View PR using the GUI difftool:
$ git pr show -t 22336

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22336.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

… resources

Cleanup of doPrivilege in:
    sun.util.calendar
    sun.util.local/provider
    sun.util.cldr
    sun.util.resources
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@RogerRiggs RogerRiggs changed the title 8344898: SM cleanup of java.base sun/util calendar, locale, clde, and resources 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources

Reviewed-by: naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
  • 4110d39: 8344865: SM cleanup in sun/reflect/annotation
  • 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
  • e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
  • cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
  • c6b14c6: 8344841: ClassPrinter prints confusing value for null
  • ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
  • 965aace: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
  • 811d08c: 8340010: Fix vectorization tests with compact headers
  • 519bb26: 8344217: Remove calls to SecurityManager and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration
  • ... and 26 more: https://git.openjdk.org/jdk/compare/6d3becb486ab38c9c2d2a6fbc428bf794375317c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix in this area. Looks good with a couple of minor nit

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the changes

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

Going to push as commit df2d4c1.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 4d898aa: 8344896: Remove obsolete checks for AWTPermission accessClipboard
  • 08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
  • 593a589: 8344319: SM cleanup in jdk.dynalink module
  • 15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
  • a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
  • 4110d39: 8344865: SM cleanup in sun/reflect/annotation
  • 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
  • e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
  • cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
  • c6b14c6: 8344841: ClassPrinter prints confusing value for null
  • ... and 30 more: https://git.openjdk.org/jdk/compare/6d3becb486ab38c9c2d2a6fbc428bf794375317c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2024
@openjdk openjdk bot closed this Nov 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2024
@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@RogerRiggs Pushed as commit df2d4c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8344898-sm-sun-util branch February 24, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants