-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources #22336
Conversation
… resources Cleanup of doPrivilege in: sun.util.calendar sun.util.local/provider sun.util.cldr sun.util.resources
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@RogerRiggs The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix in this area. Looks good with a couple of minor nit
src/java.base/share/classes/sun/util/resources/BreakIteratorResourceBundle.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the changes
/integrate |
Going to push as commit df2d4c1.
Your commit was automatically rebased without conflicts. |
@RogerRiggs Pushed as commit df2d4c1. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Cleanup of doPrivileged in:
sun.util.calendar
sun.util.local/provider
sun.util.cldr
sun.util.resources
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22336/head:pull/22336
$ git checkout pull/22336
Update a local copy of the PR:
$ git checkout pull/22336
$ git pull https://git.openjdk.org/jdk.git pull/22336/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22336
View PR using the GUI difftool:
$ git pr show -t 22336
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22336.diff
Using Webrev
Link to Webrev Comment