-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8343004: Adjust JAXP limits #22337
8343004: Adjust JAXP limits #22337
Conversation
👋 Welcome back joehw! A progress list of the required criteria for merging this PR into |
@JoeWang-Java This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@JoeWang-Java The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joe,
The changes look good overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine
*/ | ||
public class ImplProperties { | ||
// JDK Implementation Specific Properties, refer to module description | ||
public static final String[] PROPERTY_KEYS = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test would be easier to maintain if the Properties were defined as an enum, each with its related values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will look into that. Added to JDK-8344999.
@@ -100,23 +100,23 @@ public final class XMLSecurityManager { | |||
@SuppressWarnings("deprecation") | |||
public static enum Limit { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary to have both a default and secure value anymore? All the values are the same for both AFACT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll start a discussion as related to the JEP, whether to keep FSP as the approach has changed. For now, the values for enableExtensionFunctions are still different. If there's a conclusion, I can make the change via that PR.
/integrate |
Going to push as commit 28c8729.
Your commit was automatically rebased without conflicts. |
@JoeWang-Java Pushed as commit 28c8729. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Adjust JAXP Limits. Limits are adjusted as specified in the CSR.
Tests:
Updated the config test with the new settings.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22337/head:pull/22337
$ git checkout pull/22337
Update a local copy of the PR:
$ git checkout pull/22337
$ git pull https://git.openjdk.org/jdk.git pull/22337/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22337
View PR using the GUI difftool:
$ git pr show -t 22337
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22337.diff
Using Webrev
Link to Webrev Comment