Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344967: Some tests in TestFill do not use the test parameter #22413

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Nov 27, 2024

This trivial PR proposes to use the parameter length for two tests as originally intended.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344967: Some tests in TestFill do not use the test parameter (Bug - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22413/head:pull/22413
$ git checkout pull/22413

Update a local copy of the PR:
$ git checkout pull/22413
$ git pull https://git.openjdk.org/jdk.git pull/22413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22413

View PR using the GUI difftool:
$ git pr show -t 22413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22413.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
minborg Per-Ake Minborg
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344967: Some tests in TestFill do not use the test parameter

Reviewed-by: jvernee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 0312694: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory
  • 75f3ec7: 8344766: AES/CTR slow at big payloads
  • 35bd2f3: 8344555: SM cleanup - drop reflection filter of System.security field
  • a491564: 8342836: Automatically determine that a test in the docs test root is requested
  • b89cba7: 8342808: Javadoc should add whitespace between type parameters
  • 0b704a2: 8343239: Javadoc marks non-preview type as preview if it's the subtype of a preview type

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 27, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2024
@minborg
Copy link
Contributor Author

minborg commented Nov 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

Going to push as commit 1033385.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 81c44e5: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs
  • ce9d543: 8345119: Some java/foreign tests wrongly assume aligned memory
  • 1a07d54: 8343703: Symbol name cleanups after JEP 479
  • a0df0a5: 8340731: Cleanup remaining IA64 references in hotspot code
  • 8485cb1: 8344822: CDS BulkLoaderTest.java#dynamic fails with COH
  • f51363e: 8344913: Improve -Xlog:cds+map+oop logging for Java mirrors
  • cf5ee0b: 8342280: Deprecate for removal java.awt.AWTPermission
  • 8ad0b2a: 8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references
  • f6d2990: 8344824: CDS dump crashes when member_method of a lambda proxy is null
  • 15378a7: 8345126: [BACKOUT] JDK-8318127: align_up has potential overflow
  • ... and 9 more: https://git.openjdk.org/jdk/compare/ac3bbf7ddc1f6a55682264d66282e6ee8825f47a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2024
@openjdk openjdk bot closed this Nov 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@minborg Pushed as commit 1033385.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants