Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345397: Remove <cstdio> from g1HeapRegionRemSet.cpp #22519

Closed
wants to merge 1 commit into from

Conversation

kimbarrett
Copy link

@kimbarrett kimbarrett commented Dec 3, 2024

Please review this trivial removal of an unnecessary and improperly placed
include of <cstdio>.

Testing: mach5 tier1


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345397: Remove <cstdio> from g1HeapRegionRemSet.cpp (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22519/head:pull/22519
$ git checkout pull/22519

Update a local copy of the PR:
$ git checkout pull/22519
$ git pull https://git.openjdk.org/jdk.git pull/22519/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22519

View PR using the GUI difftool:
$ git pr show -t 22519

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22519.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

👋 Welcome back kbarrett! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@kimbarrett This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345397: Remove <cstdio> from g1HeapRegionRemSet.cpp

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 3eaa761: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)
  • 60bd73a: 8342089: Require --enable-native-access to be the same between CDS dump time and run time
  • 2be27e1: 8345393: ProblemList java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java on generic-all JTREG_TEST_THREAD_FACTORY=Virtual
  • ba50939: 8341649: Regressions with large metaspace apps after 8338526
  • caf053b: 8337287: Update image in javax.swing.text.Document.insert
  • 8647c00: 8342602: Remove JButton/PressedButtonRightClickTest test
  • fcf185c: 8345325: SM cleanup of GetPropertyAction in java.base
  • eac00f6: 8345396: Fix headers after JDK-8345164

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@kimbarrett The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Dec 3, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2024
@kimbarrett
Copy link
Author

Thanks for reviewing @shipilev

@kimbarrett
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

Going to push as commit e1910f2.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
  • 3eaa761: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)
  • 60bd73a: 8342089: Require --enable-native-access to be the same between CDS dump time and run time
  • 2be27e1: 8345393: ProblemList java/util/concurrent/locks/StampedLock/OOMEInStampedLock.java on generic-all JTREG_TEST_THREAD_FACTORY=Virtual
  • ba50939: 8341649: Regressions with large metaspace apps after 8338526
  • caf053b: 8337287: Update image in javax.swing.text.Document.insert
  • 8647c00: 8342602: Remove JButton/PressedButtonRightClickTest test
  • fcf185c: 8345325: SM cleanup of GetPropertyAction in java.base
  • eac00f6: 8345396: Fix headers after JDK-8345164

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 3, 2024
@openjdk openjdk bot closed this Dec 3, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2024
@kimbarrett kimbarrett deleted the no-cstdio branch December 3, 2024 16:31
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@kimbarrett Pushed as commit e1910f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants