Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler #22626

Closed
wants to merge 2 commits into from

Conversation

lmesnik
Copy link
Member

@lmesnik lmesnik commented Dec 7, 2024

The test group
:resourcehogs/compiler
contains tests that should not be executed concurrently with any tests.

They might use a lot of resources and cause unexplained sporadic failures of other tests.

So it should be removed from :hotspot_slow_compiler.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22626/head:pull/22626
$ git checkout pull/22626

Update a local copy of the PR:
$ git checkout pull/22626
$ git pull https://git.openjdk.org/jdk.git pull/22626/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22626

View PR using the GUI difftool:
$ git pr show -t 22626

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22626.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2024

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 7, 2024

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 69e664d: 8345632: [ASAN] memory leak in get_numbered_property_as_sorted_string function
  • 842b363: 8345698: Remove tier1_compiler_not_xcomp from github actions
  • 458979d: 8344611: Add missing classpath exception
  • 83ea013: 8345629: Remove expired flags in JDK 25
  • c517ffb: 8339910: RISC-V: crc32 intrinsic with carry-less multiplication

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 7, 2024
@openjdk
Copy link

openjdk bot commented Dec 7, 2024

@lmesnik The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Dec 7, 2024
@lmesnik
Copy link
Member Author

lmesnik commented Dec 7, 2024

/cc hotspot-compiler

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Dec 7, 2024
@openjdk
Copy link

openjdk bot commented Dec 7, 2024

@lmesnik
The hotspot-compiler label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Dec 7, 2024

Webrevs

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 8, 2024
@lmesnik
Copy link
Member Author

lmesnik commented Dec 10, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 10, 2024

Going to push as commit d6b5264.
Since your change was applied there have been 30 commits pushed to the master branch:

  • 4f855d1: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
  • a24b08f: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
  • 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
  • a6277bb: 8340212: -Xshare:off -XX:CompressedClassSpaceBaseAddress=0x40001000000 crashes on macos-aarch64
  • 165fd84: 8342987: Update --release 24 symbol information for JDK 24 build 27
  • 06c44dd: 8345465: Fix performance regression on x64 after JDK-8345120
  • 2979806: 8345795: Update copyright year to 2024 for hotspot in files where it was missed
  • 7e73c43: 8345217: Parallel: Refactor PSParallelCompact::next_src_region
  • 7d3a404: 8339019: Obsolete the UseLinuxPosixThreadCPUClocks flag
  • a606836: 8345744: Use C++ LINK_TYPE with SetupBuildLauncher in StaticLibs.gmk
  • ... and 20 more: https://git.openjdk.org/jdk/compare/e0d639878346946d0627a57b0eeb0cac8ca533fc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 10, 2024
@openjdk openjdk bot closed this Dec 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 10, 2024
@openjdk
Copy link

openjdk bot commented Dec 10, 2024

@lmesnik Pushed as commit d6b5264.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants