Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8346142: [perf] scalability issue for the specjvm2008::xml.validation workload #22723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

IvaVladimir
Copy link

@IvaVladimir IvaVladimir commented Dec 13, 2024

The double check needs less time vs enter to 'synchronize' block when it not needed. This patch for the xml.validation workload for runs with 112 threads reports ~2.5% improvement on the server with Xeon 8480:
orig: 1T - 433.64 ops/m, 112T - 17344.25 ops/m
patched: 1T - 437.01 ops/m, 112T - 17771.94 ops/m

The tier1 and jaxp tests are OK with this patch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346142: [perf] scalability issue for the specjvm2008::xml.validation workload (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22723/head:pull/22723
$ git checkout pull/22723

Update a local copy of the PR:
$ git checkout pull/22723
$ git pull https://git.openjdk.org/jdk.git pull/22723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22723

View PR using the GUI difftool:
$ git pr show -t 22723

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22723.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2024

👋 Welcome back vaivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title 8346142 [perf] scalability issue for the specjvm2008::xml.validation … 8346142: [perf] scalability issue for the specjvm2008::xml.validation workload Dec 13, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 13, 2024
@openjdk
Copy link

openjdk bot commented Dec 13, 2024

@IvaVladimir The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Dec 13, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 13, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant