Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException #22960

Closed
wants to merge 1 commit into from

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jan 8, 2025

Since JDK-8285417 is now closed as a dup of JDK-8347137, its problem list entry needs to be updated.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22960/head:pull/22960
$ git checkout pull/22960

Update a local copy of the PR:
$ git checkout pull/22960
$ git pull https://git.openjdk.org/jdk.git pull/22960/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22960

View PR using the GUI difftool:
$ git pr show -t 22960

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22960.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2025

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException

Reviewed-by: kevinw, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
  • 49ee4df: 8166983: Remove old/legacy unused tzdata files
  • 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
  • 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
  • ae3fc46: 8345580: Remove const from Node::_idx which is modified
  • 4d18e5a: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
  • 92ad8a1: 8346052: JFR: Incorrect average value in 'jfr view'
  • 672c413: 8345337: JFR: jfr view should display all direct subfields for an event type
  • afe5434: 8347163: Javadoc error in ConstantPoolBuilder after JDK-8342468
  • f696d9c: 8346239: Improve memory efficiency of JimageDiffGenerator
  • ... and 4 more: https://git.openjdk.org/jdk/compare/bcefab5e55d4527a38dcab550581a734c1564608...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8347162 8347162: Update problemlist CR for vmTestbase/nsk/jdi/VMOutOfMemoryException Jan 8, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@plummercj To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@jaikiran
Copy link
Member

jaikiran commented Jan 8, 2025

/label add serviceability

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@jaikiran
The serviceability label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 8, 2025

Webrevs

Copy link
Contributor

@kevinjwalls kevinjwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2025
@plummercj
Copy link
Contributor Author

Thank you Alex and Kevin!

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2025

Going to push as commit 0a5ef82.
Since your change was applied there have been 18 commits pushed to the master branch:

  • ea49537: 8310340: assert(_thread->is_interp_only_mode() || stub_caller) failed: expected a stub-caller
  • 2e00816: 8346671: java/nio/file/Files/probeContentType/Basic.java fails on Windows 2025
  • 88fa3b2: 8346998: Test nsk/jvmti/ResourceExhausted/resexhausted003 fails with java.lang.OutOfMemoryError when CDS is off
  • 6ee2bd2: 8347147: [REDO] AccessFlags can be u2 in metadata
  • a641932: 8346310: Duplicate !HAS_PENDING_EXCEPTION check in DynamicArchive::dump_at_exit
  • 49ee4df: 8166983: Remove old/legacy unused tzdata files
  • 3fe0818: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
  • 55bcf4c: 8346047: JFR: Incorrect percentile value in 'jfr view'
  • ae3fc46: 8345580: Remove const from Node::_idx which is modified
  • 4d18e5a: 8346872: tools/jpackage/windows/WinLongPathTest.java fails
  • ... and 8 more: https://git.openjdk.org/jdk/compare/bcefab5e55d4527a38dcab550581a734c1564608...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 8, 2025
@openjdk openjdk bot closed this Jan 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2025
@openjdk
Copy link

openjdk bot commented Jan 8, 2025

@plummercj Pushed as commit 0a5ef82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

4 participants