-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8347609: Replace SIZE_FORMAT in os/os_cpu/cpu directories #23106
Conversation
👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into |
@coleenp This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 54 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good, I have a few questions and considerations:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matias9927 Thank you for the reformatting suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
Thanks Matias and David! |
Going to push as commit d218b54.
Your commit was automatically rebased without conflicts. |
Please review this change to replace SIZE_FORMAT with %zu in the os, os_cpu and cpu directories. There weren't very many. Most was done with a script with very little hand-editing. Added 2 whitespaces in arm.ad.
Tested just now with tier1-4 on x86 and aarch64, GHA for the rest.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23106/head:pull/23106
$ git checkout pull/23106
Update a local copy of the PR:
$ git checkout pull/23106
$ git pull https://git.openjdk.org/jdk.git pull/23106/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23106
View PR using the GUI difftool:
$ git pr show -t 23106
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23106.diff
Using Webrev
Link to Webrev Comment