Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8347609: Replace SIZE_FORMAT in os/os_cpu/cpu directories #23106

Closed
wants to merge 2 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jan 14, 2025

Please review this change to replace SIZE_FORMAT with %zu in the os, os_cpu and cpu directories. There weren't very many. Most was done with a script with very little hand-editing. Added 2 whitespaces in arm.ad.
Tested just now with tier1-4 on x86 and aarch64, GHA for the rest.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8347609: Replace SIZE_FORMAT in os/os_cpu/cpu directories (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23106/head:pull/23106
$ git checkout pull/23106

Update a local copy of the PR:
$ git checkout pull/23106
$ git pull https://git.openjdk.org/jdk.git pull/23106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23106

View PR using the GUI difftool:
$ git pr show -t 23106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23106.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 14, 2025

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347609: Replace SIZE_FORMAT in os/os_cpu/cpu directories

Reviewed-by: matsaave, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8347609 Replace SIZE_FORMAT in os/os_cpu/cpu directories 8347609: Replace SIZE_FORMAT in os/os_cpu/cpu directories Jan 14, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 14, 2025
@openjdk
Copy link

openjdk bot commented Jan 14, 2025

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 14, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 14, 2025

Webrevs

Copy link
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, I have a few questions and considerations:

Copy link
Contributor Author

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matias9927 Thank you for the reformatting suggestions.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 16, 2025
Copy link
Contributor

@matias9927 matias9927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@coleenp
Copy link
Contributor Author

coleenp commented Jan 16, 2025

Thanks Matias and David!
/integrate

@openjdk
Copy link

openjdk bot commented Jan 16, 2025

Going to push as commit d218b54.
Since your change was applied there have been 54 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 16, 2025
@openjdk openjdk bot closed this Jan 16, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 16, 2025
@openjdk
Copy link

openjdk bot commented Jan 16, 2025

@coleenp Pushed as commit d218b54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the zmod-os-cpu branch January 16, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants