8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser #23128

kumarabhi006 · 2025-01-15T09:30:03Z

There are no tabs available for GTK Look and Feel due to the different ColorChooser UI design. Updated the test to skip testing for GTK L&F.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser (Bug - P4)

Reviewers

Alexey Ivanov (@aivanov-jdk - Reviewer)
Alexander Zuev (@azuev-java - Reviewer) Review applies to f5f7df45
Alexander Zvegintsev (@azvegint - Reviewer)
Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23128/head:pull/23128
$ git checkout pull/23128

Update a local copy of the PR:
$ git checkout pull/23128
$ git pull https://git.openjdk.org/jdk.git pull/23128/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23128

View PR using the GUI difftool:
$ git pr show -t 23128

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23128.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-01-15T09:30:59Z

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-01-15T09:31:26Z

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser

Reviewed-by: aivanov, azvegint, prr, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

c38417a: 8348186: C1: Purge fpu_stack_size infrastructure
f2a9d26: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing
25fecaa: 8348039: testmake fails at IDEA after JDK-8347825
6a29a81: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause
81912e9: 8347841: Test fixes that use deprecated time zone IDs
3d4afc4: 8345079: Simplify/cleanup Exception handling in RMIConnectionImpl
a62a870: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
8e8c948: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer
1ed396b: 8346927: serviceability/dcmd/vm/[SystemMapTest.java|SystemDumpMapTest.java] fail at jmx
5c4a387: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
... and 72 more: https://git.openjdk.org/jdk/compare/973c630777d4075bc85c7ddc1eb02cc65904344d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-01-15T09:32:01Z

@kumarabhi006 The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-01-15T09:34:49Z

Webrevs

lawrence-andrew · 2025-01-15T16:53:59Z

LGTM

prsadhuk · 2025-01-16T04:07:31Z

test/jdk/javax/swing/JColorChooser/Test8152419.java

@@ -43,9 +43,18 @@
 import javax.swing.UIManager;
 import javax.swing.border.EmptyBorder;

+import jtreg.SkippedException;


jtreg tag @library needs to be added for this

aivanov-jdk

Looks good, except for minor comments.

aivanov-jdk · 2025-01-20T18:52:07Z

test/jdk/javax/swing/JColorChooser/Test8152419.java

    public static void main(String args[]) throws Exception {
+
+        // ColorChooser UI design is different for GTK L&F.
+        // There are no tabs available for GTK L&F, skip the testing.


Suggested change

public static void main(String args[]) throws Exception {

// ColorChooser UI design is different for GTK L&F.

// There are no tabs available for GTK L&F, skip the testing.

public static void main(String args[]) throws Exception {

// ColorChooser UI design is different for GTK L&F.

// There are no tabs in GTK L&F, skip the testing.

No blank line at the start of a method; subtle change in comment.

aivanov-jdk · 2025-01-20T18:54:01Z

test/jdk/javax/swing/JColorChooser/Test8152419.java

 /*
 * @test
 * @bug 8152419
+* @library /test/lib
 * @summary To Verify JColorChooser tab selection
 * @run main/manual Test8152419
 */


Suggested change

/*

* @test

* @bug 8152419

* @library /test/lib

* @summary To Verify JColorChooser tab selection

* @run main/manual Test8152419

*/

/*

* @test

* @bug 8152419

* @library /test/lib

* @summary To Verify JColorChooser tab selection

* @run main/manual Test8152419

*/

The formatting of the jtreg tags looks weird.

Usually, the opening /* starts in the first column, and the following * are aligned to the first one.

I saw that and then forget to change. Updated now.

azuev-java

Looks good.

kumarabhi006 · 2025-01-22T05:50:35Z

/integrate

openjdk · 2025-01-22T05:51:39Z

Going to push as commit 8458f88.
Since your change was applied there have been 84 commits pushed to the master branch:

7a6ff92: 8345543: Test serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java failed: expected JVMTI_ERROR_OPAQUE_FRAME instead of: 0
bbd8807: 8338428: Add logging of final VM flags while setting properties
c38417a: 8348186: C1: Purge fpu_stack_size infrastructure
f2a9d26: 8347740: java/io/File/createTempFile/SpecialTempFile.java failing
25fecaa: 8348039: testmake fails at IDEA after JDK-8347825
6a29a81: 8345750: Shenandoah: Test TestJcmdHeapDump.java#aggressive intermittent assert(gc_cause() == GCCause::_no_gc) failed: Over-writing cause
81912e9: 8347841: Test fixes that use deprecated time zone IDs
3d4afc4: 8345079: Simplify/cleanup Exception handling in RMIConnectionImpl
a62a870: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
8e8c948: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer
... and 74 more: https://git.openjdk.org/jdk/compare/973c630777d4075bc85c7ddc1eb02cc65904344d...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-22T05:51:50Z

@kumarabhi006 Pushed as commit 8458f88.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Test update

Loading
Loading status checks…

9873208

openjdk bot changed the title ~~8347475: GTK: javax/swing/JColorChooser/Test8152419.java there is no swatches or RGB tab in JColorChooser~~ 8347475: GTK: javax/swing/JColorChooser/Test8152419.java there is no swatches or RGB tab in JColorChooser Jan 15, 2025

openjdk bot added the rfr label Jan 15, 2025

openjdk bot added the client label Jan 15, 2025

prsadhuk reviewed Jan 16, 2025

View reviewed changes

jtreg library tag added

f5f7df4

aivanov-jdk approved these changes Jan 20, 2025

View reviewed changes

openjdk bot added the ready label Jan 20, 2025

azuev-java approved these changes Jan 21, 2025

View reviewed changes

Formatting changes

790ce7d

openjdk bot removed the ready label Jan 21, 2025

azvegint approved these changes Jan 21, 2025

View reviewed changes

openjdk bot added ready and removed ready labels Jan 21, 2025

aivanov-jdk approved these changes Jan 21, 2025

View reviewed changes

kumarabhi006 changed the title ~~8347475: GTK: javax/swing/JColorChooser/Test8152419.java there is no swatches or RGB tab in JColorChooser~~ 8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser Jan 21, 2025

openjdk bot added the ready label Jan 21, 2025

prrace approved these changes Jan 21, 2025

View reviewed changes

openjdk bot added the integrated label Jan 22, 2025

openjdk bot closed this Jan 22, 2025

openjdk bot removed ready rfr labels Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser #23128

8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser #23128

kumarabhi006 commented Jan 15, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jan 15, 2025

openjdk bot commented Jan 15, 2025 •

edited

Loading

openjdk bot commented Jan 15, 2025

mlbridge bot commented Jan 15, 2025 •

edited

Loading

lawrence-andrew commented Jan 15, 2025

prsadhuk Jan 16, 2025

kumarabhi006 Jan 20, 2025

aivanov-jdk left a comment

aivanov-jdk Jan 20, 2025

aivanov-jdk Jan 20, 2025

kumarabhi006 Jan 21, 2025

azuev-java left a comment

kumarabhi006 commented Jan 22, 2025

openjdk bot commented Jan 22, 2025

openjdk bot commented Jan 22, 2025

8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser #23128

8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser #23128

Conversation

kumarabhi006 commented Jan 15, 2025 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jan 15, 2025

openjdk bot commented Jan 15, 2025 • edited Loading

openjdk bot commented Jan 15, 2025

mlbridge bot commented Jan 15, 2025 • edited Loading

Webrevs

lawrence-andrew commented Jan 15, 2025

prsadhuk Jan 16, 2025

Choose a reason for hiding this comment

kumarabhi006 Jan 20, 2025

Choose a reason for hiding this comment

aivanov-jdk left a comment

Choose a reason for hiding this comment

aivanov-jdk Jan 20, 2025

Choose a reason for hiding this comment

aivanov-jdk Jan 20, 2025

Choose a reason for hiding this comment

kumarabhi006 Jan 21, 2025

Choose a reason for hiding this comment

azuev-java left a comment

Choose a reason for hiding this comment

kumarabhi006 commented Jan 22, 2025

openjdk bot commented Jan 22, 2025

openjdk bot commented Jan 22, 2025

kumarabhi006 commented Jan 15, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 15, 2025 •

edited

Loading

mlbridge bot commented Jan 15, 2025 •

edited

Loading