8348029: Make gtest death tests work with real crash signals

[tstuefe]

Small change adds a new macro to the gtest TEST macro zoo: TEST_VM_CRASH_SIGNAL. This one is a companion to TEST_VM_FATAL_ERROR_MSG and TEST_VM_ASSERT_MSG and allows to write gtest that test expected crashes to happen. I will need that for a regression test for https://bugs.openjdk.org/browse/JDK-8330174 , among other things.

You use it like this:

TEST_VM_CRASH_SIGNAL(Testtest, test, "SIGSEGV") {
  ... do something that you expect should result in a specific crash ...
}

Note that the string provided is platform dependent (signal names on Posix, SEH names on Windows).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348029: Make gtest death tests work with real crash signals (Enhancement - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Sonia Zaldana Calles (@SoniaZaldana - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23191/head:pull/23191
$ git checkout pull/23191

Update a local copy of the PR:
$ git checkout pull/23191
$ git pull https://git.openjdk.org/jdk.git pull/23191/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23191

View PR using the GUI difftool:
$ git pr show -t 23191

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23191.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348029: Make gtest death tests work with real crash signals

Reviewed-by: mbaesken, szaldana

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ca863fd: 8347758: modules.cpp leaks string returned from get_numbered_property_as_sorted_string()
• 3a4d5ff: 8347996: JavaCompilation.gmk should not include ZipArchive.gmk
• 0fbf10a: 8348038: Docs build failing in Options.notifyListeners with AssertionError
• 9346984: 8347916: Simplify javax.swing.text.html.CSS.LengthUnit.getValue
• 3c92392: 8348089: Serial: Remove virtual specifier in SerialHeap
• ... and 9 more: https://git.openjdk.org/jdk/compare/0ff67000dc22e8c58e8a9ed1379010f4a2ad7666...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (93b880d9)

[SoniaZaldana]

I am not a Reviewer but this looks good to me. Also very useful! Thanks @tstuefe.

[tstuefe]

Thanks @MBaesken and @SoniaZaldana

/integrate

[openjdk]

Going to push as commit 48c7597.
Since your change was applied there have been 20 commits pushed to the master branch:

• 4a9fba6: 8347990: Remove SIZE_FORMAT macros and replace remaining uses
• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ca863fd: 8347758: modules.cpp leaks string returned from get_numbered_property_as_sorted_string()
• 3a4d5ff: 8347996: JavaCompilation.gmk should not include ZipArchive.gmk
• 0fbf10a: 8348038: Docs build failing in Options.notifyListeners with AssertionError
• 9346984: 8347916: Simplify javax.swing.text.html.CSS.LengthUnit.getValue
• ... and 10 more: https://git.openjdk.org/jdk/compare/0ff67000dc22e8c58e8a9ed1379010f4a2ad7666...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tstuefe Pushed as commit 48c7597.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.