8344925: translet-name ignored when package-name is also set #23446

JoeWang-Java · 2025-02-04T18:30:34Z

Fix an issue where the translet-name is incorrectly set when the package-name is also specified.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8344925: translet-name ignored when package-name is also set (Bug - P4)

Reviewers

Lance Andersen (@LanceAndersen - Reviewer)
Naoto Sato (@naotoj - Reviewer) Review applies to df9b015a
Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23446/head:pull/23446
$ git checkout pull/23446

Update a local copy of the PR:
$ git checkout pull/23446
$ git pull https://git.openjdk.org/jdk.git pull/23446/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23446

View PR using the GUI difftool:
$ git pr show -t 23446

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23446.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-02-04T18:31:26Z

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-02-04T18:32:00Z

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344925: translet-name ignored when package-name is also set

Reviewed-by: lancea, iris, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

1079147: 8348570: CTW: Expose the code hidden by uncommon traps
1a74ee6: 8349092: File.getFreeSpace violates specification if quotas are in effect (win)
0181030: 8349006: File.getCanonicalPath should remove "(on UNIX platforms)" from its specification
ed8945a: 8347377: Add validation checks for ICC_Profile header fields
1ab1c1d: 8349058: 'internal proprietary API' warnings make javac warnings unusable
eb84702: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads
f12d2de: 8345212: Since checker should better handle non numeric values
5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
3fbae32: 8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer
e0487c7: 8346777: Add missing const declarations and rename variables
... and 29 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-02-04T18:32:30Z

@JoeWang-Java The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-02-04T18:36:38Z

Webrevs

01: Full - Incremental (a31ac5e1)
00: Full (df9b015a)

jerboaa · 2025-02-05T10:47:27Z

@JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?

jerboaa · 2025-02-05T10:57:14Z

@JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?

Just mentioning since it looks like a duplicate proposal.

JoeWang-Java · 2025-02-05T18:03:25Z

@JoeWang-Java Have you seen https://git.openjdk.org/jdk/pull/22425?

Just mentioning since it looks like a duplicate proposal.

Indeed, I missed that. The right procedure to take over an issue is to ask the person assigned to the bug, that would avoid any confusion and duplicate effort. Unfortunately, he never asked me.

jerboaa · 2025-02-06T17:58:08Z

test/jaxp/javax/xml/jaxp/unittest/transform/PropertiesTest.java

+        String path = (destination != null) ? destination + expected : new File(xslFile).getParent() + expected;
+
+        if (generateTranslet) {
+            //Files.list(Path.of(path)).forEach(System.out::println);


Left over from testing the test? I'd suggest to remove this commented out code.

Removed. Thanks.

naotoj · 2025-02-06T18:04:47Z

test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java

+public class JUnitTestUtil {
+    public static final String CLS_DIR = System.getProperty("test.classes");
+    public static final String SRC_DIR = System.getProperty("test.src");
+    public static final boolean isWindows = System.getProperty("os.name").contains("Windows");


It is good as it stands, but Platform.isWindows() can be used here

Updated using the test lib. Thanks.

JoeWang-Java · 2025-02-07T02:25:15Z

/integrate

openjdk · 2025-02-07T02:26:20Z

Going to push as commit 3989a19.
Since your change was applied there have been 41 commits pushed to the master branch:

1eb54e4: 8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings
a0c7f66: 8349508: runtime/cds/appcds/TestParallelGCWithCDS.java should not check for specific output
1079147: 8348570: CTW: Expose the code hidden by uncommon traps
1a74ee6: 8349092: File.getFreeSpace violates specification if quotas are in effect (win)
0181030: 8349006: File.getCanonicalPath should remove "(on UNIX platforms)" from its specification
ed8945a: 8347377: Add validation checks for ICC_Profile header fields
1ab1c1d: 8349058: 'internal proprietary API' warnings make javac warnings unusable
eb84702: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads
f12d2de: 8345212: Since checker should better handle non numeric values
5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
... and 31 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-02-07T02:26:30Z

@JoeWang-Java Pushed as commit 3989a19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8344925: translet-name ignored when package-name is also set

b56a171

openjdk bot added the rfr label Feb 4, 2025

openjdk bot added the core-libs label Feb 4, 2025

update copyright

df9b015

LanceAndersen approved these changes Feb 6, 2025

View reviewed changes

openjdk bot added the ready label Feb 6, 2025

jerboaa reviewed Feb 6, 2025

View reviewed changes

naotoj approved these changes Feb 6, 2025

View reviewed changes

update test

a31ac5e

openjdk bot removed the ready label Feb 6, 2025

LanceAndersen approved these changes Feb 6, 2025

View reviewed changes

openjdk bot added the ready label Feb 6, 2025

irisclark approved these changes Feb 6, 2025

View reviewed changes

openjdk bot added the integrated label Feb 7, 2025

openjdk bot closed this Feb 7, 2025

openjdk bot removed ready rfr labels Feb 7, 2025

JoeWang-Java deleted the JDK-8344925 branch February 7, 2025 02:44

jerboaa mentioned this pull request Feb 7, 2025

8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute #22425

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8344925: translet-name ignored when package-name is also set #23446

8344925: translet-name ignored when package-name is also set #23446

JoeWang-Java commented Feb 4, 2025 •

edited by openjdk bot

Loading

bridgekeeper bot commented Feb 4, 2025

openjdk bot commented Feb 4, 2025 •

edited

Loading

openjdk bot commented Feb 4, 2025

mlbridge bot commented Feb 4, 2025 •

edited

Loading

jerboaa commented Feb 5, 2025

jerboaa commented Feb 5, 2025

JoeWang-Java commented Feb 5, 2025

jerboaa Feb 6, 2025

JoeWang-Java Feb 6, 2025

naotoj Feb 6, 2025

JoeWang-Java Feb 6, 2025

JoeWang-Java commented Feb 7, 2025

openjdk bot commented Feb 7, 2025

openjdk bot commented Feb 7, 2025

8344925: translet-name ignored when package-name is also set #23446

8344925: translet-name ignored when package-name is also set #23446

Conversation

JoeWang-Java commented Feb 4, 2025 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Feb 4, 2025

openjdk bot commented Feb 4, 2025 • edited Loading

openjdk bot commented Feb 4, 2025

mlbridge bot commented Feb 4, 2025 • edited Loading

Webrevs

jerboaa commented Feb 5, 2025

jerboaa commented Feb 5, 2025

JoeWang-Java commented Feb 5, 2025

jerboaa Feb 6, 2025

Choose a reason for hiding this comment

JoeWang-Java Feb 6, 2025

Choose a reason for hiding this comment

naotoj Feb 6, 2025

Choose a reason for hiding this comment

JoeWang-Java Feb 6, 2025

Choose a reason for hiding this comment

JoeWang-Java commented Feb 7, 2025

openjdk bot commented Feb 7, 2025

openjdk bot commented Feb 7, 2025

JoeWang-Java commented Feb 4, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Feb 4, 2025 •

edited

Loading

mlbridge bot commented Feb 4, 2025 •

edited

Loading