8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer

[sendaoYan]

Hi all,
Test function os_attempt_reserve_memory_between_combos_vm_Test::TestBody() in "test/hotspot/gtest/runtime/test_os_reserve_between.cpp" file reported "applying non-zero offset 4096 to null pointer" by UndefinedBehaviorSanitizer. The var min cast from 0 to pointer and then apply non-zero offset range_size is undefined behavior.

This PR cast pointer min to uintptr_t before add the offset range_size, and the cast back to pointer. This solution similar to JDK-8346714. This PR do not change the original logic but eliminate the undefined behaviour in code.

Change has been verified locally, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Amit Kumar (@offamitkumar - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23462/head:pull/23462
$ git checkout pull/23462

Update a local copy of the PR:
$ git checkout pull/23462
$ git pull https://git.openjdk.org/jdk.git pull/23462/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23462

View PR using the GUI difftool:
$ git pr show -t 23462

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23462.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer

Reviewed-by: mdoerr, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
• 4618993: 8349537: Bad copyright in TestArrayStructs.java
• acb46dd: 8345155: Add /native to native test in FFM
• d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
• 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
• 3eb57f6: 8349140: Size optimization (opt-size) build fails after recent PCH changes
• 3cf04de: 8349132: javac Analyzers should handle non-deferrable errors
• 30f7162: 8349417: Fix NULL usage from JDK-8346433
• 64bd8d2: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing
• 5e1cc08: 8349504: Support platform-specific JUnit tests in jpackage
• ... and 10 more: https://git.openjdk.org/jdk/compare/61465883b465a184e31e7a03e2603d29ab4815a4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (72f79f45)

[TheRealMDoerr]

LGTM.

[sendaoYan]

Thanks all for the reviews.

/integrate

[openjdk]

Going to push as commit 3fbae32.
Since your change was applied there have been 23 commits pushed to the master branch:

• e0487c7: 8346777: Add missing const declarations and rename variables
• 2b82e2d: 8347958: Minor compiler cleanups relating to MandatoryWarningHandler
• 2093bb7: 8346434: Add test for non-automatic service binding
• dd8720e: 8348520: [s390x] Problemlist TestVectorReinterpret.java
• 4618993: 8349537: Bad copyright in TestArrayStructs.java
• acb46dd: 8345155: Add /native to native test in FFM
• d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
• 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
• 3eb57f6: 8349140: Size optimization (opt-size) build fails after recent PCH changes
• 3cf04de: 8349132: javac Analyzers should handle non-deferrable errors
• ... and 13 more: https://git.openjdk.org/jdk/compare/61465883b465a184e31e7a03e2603d29ab4815a4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 3fbae32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.