8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

[jnimeh]

This takes a few test classes and moves them away from their current location in test/jdk/java/security/testlibrary to test/lib/jdk/test/lib/security, grouping them together with many other existing test utility classes. It also changes the dependent security tests to point at the new locations for these classes, as needed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer) Review applies to f5e2ca1c
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23531/head:pull/23531
$ git checkout pull/23531

Update a local copy of the PR:
$ git checkout pull/23531
$ git pull https://git.openjdk.org/jdk.git pull/23531/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23531

View PR using the GUI difftool:
$ git pr show -t 23531

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23531.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jnimeh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jnimeh This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349501: Relocate supporting classes in security/testlibrary to test/lib/jdk tree

Reviewed-by: rhalade, weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

• ab66c82: 8349639: jfr/event/gc/detailed/TestShenandoahEvacuationInformationEvent.java fails to compile after JDK-8348610
• f74c4df: 8349580: Do not use address in MemTracker top level functions
• c9cadbd: 8346567: Make Class.getModifiers() non-native
• 5589892: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated
• d104deb: 8349556: RISC-V: improve the performance when -COH and -AvoidUnalignedAccesses for UL and LU string comparison
• 4a83ca1: 8349666: RISC-V: enable superwords tests for vector reductions
• 8f6ccde: 8349554: [UBSAN] os::attempt_reserve_memory_between reported applying non-zero offset to non-null pointer produced null pointer
• 7d52f1e: 8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees
• e9278de: 8348411: C2: Remove the control input of LoadKlassNode and LoadNKlassNode
• 5395ffa: 8327378: XMLStreamReader throws EOFException instead of XMLStreamException
• ... and 93 more: https://git.openjdk.org/jdk/compare/d589a82d08a01ae6ff87103b58d286f3c14367e5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jnimeh The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (935324ba)
• 00: Full (f5e2ca1c)

[rhalade]

Following 4 tests also need to be updated:
open/test/jdk/sun/security/tools/keytool/NssTest.java open/test/jdk/sun/security/pkcs11/ec/TestECDSA2.java open/test/jdk/sun/security/pkcs11/ec/TestECDH2.java open/test/jdk/java/security/Provider/GetServiceRace.java

[rhalade]

Thanks for the updates! LGTM

[jnimeh]

/integrate

[openjdk]

Going to push as commit b737f7f.
Since your change was applied there have been 104 commits pushed to the master branch:

• 84b32cb: 8349178: runtime/jni/atExit/TestAtExit.java should be supported on static JDK
• ab66c82: 8349639: jfr/event/gc/detailed/TestShenandoahEvacuationInformationEvent.java fails to compile after JDK-8348610
• f74c4df: 8349580: Do not use address in MemTracker top level functions
• c9cadbd: 8346567: Make Class.getModifiers() non-native
• 5589892: 8343074: test/jdk/com/sun/net/httpserver/docs/test1/largefile.txt could be generated
• d104deb: 8349556: RISC-V: improve the performance when -COH and -AvoidUnalignedAccesses for UL and LU string comparison
• 4a83ca1: 8349666: RISC-V: enable superwords tests for vector reductions
• 8f6ccde: 8349554: [UBSAN] os::attempt_reserve_memory_between reported applying non-zero offset to non-null pointer produced null pointer
• 7d52f1e: 8349525: RBTree: provide leftmost, rightmost, and a simple way to print trees
• e9278de: 8348411: C2: Remove the control input of LoadKlassNode and LoadNKlassNode
• ... and 94 more: https://git.openjdk.org/jdk/compare/d589a82d08a01ae6ff87103b58d286f3c14367e5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jnimeh Pushed as commit b737f7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.