8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel

[jianglizhou]

Please review the fix that removes libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel. Thanks

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel (Bug - P4)

Reviewers

• Brian Burkhalter (@bplb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23575/head:pull/23575
$ git checkout pull/23575

Update a local copy of the PR:
$ git checkout pull/23575
$ git pull https://git.openjdk.org/jdk.git pull/23575/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23575

View PR using the GUI difftool:
$ git pr show -t 23575

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23575.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jiangli! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jianglizhou This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349868: Remove unneeded libjava shared library dependency from jtreg test libNewDirectByteBuffer, libDirectIO and libInheritedChannel

Reviewed-by: bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• 5b75ff7: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases
• add3cd1: 8348600: Update PipeWire to 1.3.81
• efc597b: 8349564: Clean warnings found in jpackage tests when building them with -Xlint:all
• 29202d1: 8349648: Test tools/jpackage/share/JLinkOptionsTest.java fails with --enable-linkable-runtime set after JDK-8346434
• 24b7f81: 8349783: g1RemSetSummary.cpp:344:68: runtime error: member call on null pointer of type 'struct G1HeapRegion'
• ... and 21 more: https://git.openjdk.org/jdk/compare/8c09d40d6c345fda9fc7b358a53cae3b5965580b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jianglizhou The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0a48af70)

[AlanBateman]

/label add nio

[openjdk]

@AlanBateman
The nio label was successfully added.

[AlanBateman]

@bplb You may have to double check that this works for us.

[jianglizhou]

@bplb You may have to double check that this works for us.

Thanks!

@bplb, please let me know your internal testing result. If there's no additional internal test source changes in those native libraries, I think testing should not run into any issue. These tests native code only uses standard JNI APIs.

[bplb]

please let me know your internal testing result.

Sure, of course.

[bplb]

I think testing should not run into any issue

I did not find any problem for the tests in the jdk_nio group on Linux, macOS, or Windows. This test group includes in particular these tests

java/nio/jni/NewDirectByteBuffer.java
java/nio/channels/FileChannel/directio
java/nio/channels/spi/SelectorProvider/inheritedChannel

which the proposed change specifically would affect.

[jianglizhou]

I think testing should not run into any issue

I did not find any problem for the tests in the jdk_nio group on Linux, macOS, or Windows. This test group includes in particular these tests

java/nio/jni/NewDirectByteBuffer.java
java/nio/channels/FileChannel/directio
java/nio/channels/spi/SelectorProvider/inheritedChannel

which the proposed change specifically would affect.

Thank you, @bplb!

[jianglizhou]

@bplb Thanks again for the review and running internal testing!

[jianglizhou]

/integrate

[openjdk]

Going to push as commit 2eac490.
Since your change was applied there have been 31 commits pushed to the master branch:

• 6ddbcc3: 8328119: Support HKDF in SunPKCS11 (Preview)
• 28e744d: 8348092: Shenandoah: assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)
• 0b50e47: 8349753: Incorrect use of CodeBlob::is_buffer_blob() in few places
• 18958c6: 8349925: [REDO] Support static JDK in libfontmanager/freetypeScaler.c
• c2fc947: 8349378: Build splashscreen lib with SIZE optimization
• 5b75ff7: 8349907: jdk.tools.jlink.internal.plugins.ZipPlugin does not close the Deflater in exceptional cases
• add3cd1: 8348600: Update PipeWire to 1.3.81
• efc597b: 8349564: Clean warnings found in jpackage tests when building them with -Xlint:all
• 29202d1: 8349648: Test tools/jpackage/share/JLinkOptionsTest.java fails with --enable-linkable-runtime set after JDK-8346434
• 24b7f81: 8349783: g1RemSetSummary.cpp:344:68: runtime error: member call on null pointer of type 'struct G1HeapRegion'
• ... and 21 more: https://git.openjdk.org/jdk/compare/8c09d40d6c345fda9fc7b358a53cae3b5965580b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jianglizhou Pushed as commit 2eac490.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.