Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() #23968

Closed

Conversation

bplb
Copy link
Member

@bplb bplb commented Mar 10, 2025

Correct the indicated typo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23968/head:pull/23968
$ git checkout pull/23968

Update a local copy of the PR:
$ git checkout pull/23968
$ git pull https://git.openjdk.org/jdk.git pull/23968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23968

View PR using the GUI difftool:
$ git pr show -t 23968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23968.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

…emProvider.getFileSystem()
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 10, 2025

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem()

Reviewed-by: alanb, lancea, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • ffa6340: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output
  • 8d8bd0c: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
  • 73465b9: 8160327: Support for thumbnails present in APP1 marker for JPEG
  • dbdbbd4: 8348597: Update HarfBuzz to 10.4.0
  • 7999091: 8351555: Help section added in JDK-8350638 uses invalid HTML
  • 8450ae9: 8351440: Link with -reproducible on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Mar 10, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 10, 2025

Webrevs

@bplb bplb changed the title 8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystem Provider.getFileSystem() 8351505: (fs) Typo in the documentation of java.nio.file.spi.FileSystemProvider.getFileSystem() Mar 10, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2025
@bplb
Copy link
Member Author

bplb commented Mar 10, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2025

Going to push as commit f984c2b.
Since your change was applied there have been 6 commits pushed to the master branch:

  • ffa6340: 8351567: Jar Manifest test ValueUtf8Coding produces misleading diagnostic output
  • 8d8bd0c: 8349492: Update sun/security/pkcs12/KeytoolOpensslInteropTest.java to use a recent Openssl version
  • 73465b9: 8160327: Support for thumbnails present in APP1 marker for JPEG
  • dbdbbd4: 8348597: Update HarfBuzz to 10.4.0
  • 7999091: 8351555: Help section added in JDK-8350638 uses invalid HTML
  • 8450ae9: 8351440: Link with -reproducible on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2025
@openjdk openjdk bot closed this Mar 10, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2025
@openjdk
Copy link

openjdk bot commented Mar 10, 2025

@bplb Pushed as commit f984c2b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the FileSystemProvider-getFileSystem-8351505 branch March 11, 2025 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

None yet

4 participants