8352180: AttachListenerThread causes many tests to timeout on Windows

[alexmenkov]

The change fixes regression from JDK-8319055 (see David's evaluation in the CR description)

Testing: sanity tier1;
tier6, tier7 - in progress

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352180: AttachListenerThread causes many tests to timeout on Windows (Bug - P2)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24091/head:pull/24091
$ git checkout pull/24091

Update a local copy of the PR:
$ git checkout pull/24091
$ git pull https://git.openjdk.org/jdk.git pull/24091/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24091

View PR using the GUI difftool:
$ git pr show -t 24091

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24091.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352180: AttachListenerThread causes many tests to timeout on Windows

Reviewed-by: dholmes, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 38499b3: 8352084: Add more test code in TestSetupAOT.java
• 19154f7: 8351970: Retire JavaLangAccess::exit
• 3aa6d62: 8351372: Improve negative tests coverage of jpackage

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[alexmenkov]

/label add serviceability

[openjdk]

@alexmenkov
The serviceability label was successfully added.

[mlbridge]

Webrevs

• 00: Full (204188d6)

[dholmes-ora]

Fix looks good.

Any idea on why things are taking so long? Is the pipe undersized?

Thanks

[AlanBateman]

Any idea on why things are taking so long? Is the pipe undersized?

It's usually just handled by Windows although I think you can override/configure with SetNamedPipeHandleState.

[alexmenkov]

Any idea on why things are taking so long? Is the pipe undersized?

I don't think this in a buffer issue.
One problem I see is self-attach. FlushFileBuffers waits until all data is read by the client, but is we are at safepoint, the client cannot read the data

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 53c5b93.
Since your change was applied there have been 12 commits pushed to the master branch:

• b025d8c: 8350663: AArch64: Enable UseSignumIntrinsic by default
• a37d843: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings
• b891bfa: 8352022: RISC-V: Support Zfa fminm_h/fmaxm_h for float16
• 20f1bca: 8351187: Add JFR monitor notification event
• 46b3d1d: 8351382: New test containers/docker/TestMemoryWithSubgroups.java is failing
• 558c015: 8351921: G1: Pinned regions with pinned objects only reachable by native code crash VM
• f8c2122: 8352138: G1: Remove G1AddMetaspaceDependency.java test
• e1bcff3: 8345687: Improve the implementation of SegmentFactories::allocateSegment
• f4ddac5: 8331201: UBSAN enabled build reports on Linux x86_64 runtime error: shift exponent 65 is too large for 64-bit type 'long unsigned int'
• 38499b3: 8352084: Add more test code in TestSetupAOT.java
• ... and 2 more: https://git.openjdk.org/jdk/compare/3239919a5a5910922ea4cb6109f94a24c5f6b4f2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 53c5b93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.