8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing

[wangweij]

A certificate created in the test will expire on 2026-03-20. This change adds another 2000 days to it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24107/head:pull/24107
$ git checkout pull/24107

Update a local copy of the PR:
$ git checkout pull/24107
$ git pull https://git.openjdk.org/jdk.git pull/24107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24107

View PR using the GUI difftool:
$ git pr show -t 24107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24107.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 20d4fe3: 8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational
• 8e53063: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage
• c8a11f2: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372
• 4a02de8: 8352098: -Xrunjdwp fails on static JDK
• 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
• a3540be: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055
• 53c5b93: 8352180: AttachListenerThread causes many tests to timeout on Windows
• b025d8c: 8350663: AArch64: Enable UseSignumIntrinsic by default
• a37d843: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings
• b891bfa: 8352022: RISC-V: Support Zfa fminm_h/fmaxm_h for float16
• ... and 15 more: https://git.openjdk.org/jdk/compare/e62becc6ce8e1b777c3e5b78a9d9406b6389cd25...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[dholmes-ora]

To future-proof this couldn't we set the expiration date based on the current date minus X days?

[dholmes-ora]

I meant the start date sorry

[mlbridge]

Webrevs

• 00: Full (1c250dd6)

[wangweij]

The start date probably cannot change, because we have a rule SHA1 denyAfter 2019-01-01 in java.security that only denies SHA1 signatures since 2019. That said, we can calculate the days between 2018-01-01 and today next year. Is that worth doing? I just want to fix this ASAP.

[dholmes-ora]

Okay lets fix this as-is for now. Making it future-proof would be nice as a future RFE.

Thanks for the quick fix.

[wangweij]

/integrate

[openjdk]

Going to push as commit 577ede7.
Since your change was applied there have been 25 commits pushed to the master branch:

• 20d4fe3: 8351464: Shenandoah: Hang on ShenandoahController::handle_alloc_failure when run test TestAllocHumongousFragment#generational
• 8e53063: 8352275: Clean up dead code in jpackage revealed with improved negative test coverage
• c8a11f2: 8352293: jpackage tests build rpm packages on Ubuntu test machines after JDK-8351372
• 4a02de8: 8352098: -Xrunjdwp fails on static JDK
• 355b2f3: 8351374: Improve comment about queue.remove timeout in CleanerImpl.run
• a3540be: 8352163: [AIX] SIGILL in AttachOperation::ReplyWriter::write_fully after 8319055
• 53c5b93: 8352180: AttachListenerThread causes many tests to timeout on Windows
• b025d8c: 8350663: AArch64: Enable UseSignumIntrinsic by default
• a37d843: 8352015: LIBVERIFY_OPTIMIZATION remove special optimization settings
• b891bfa: 8352022: RISC-V: Support Zfa fminm_h/fmaxm_h for float16
• ... and 15 more: https://git.openjdk.org/jdk/compare/e62becc6ce8e1b777c3e5b78a9d9406b6389cd25...master

Your commit was automatically rebased without conflicts.

[openjdk]

@wangweij Pushed as commit 577ede7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.