Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI #24235

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Mar 25, 2025

A trivial fix to add {@code} to the description of splitUI methods in PassFailJFrame.Builder.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI (Sub-task - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24235/head:pull/24235
$ git checkout pull/24235

Update a local copy of the PR:
$ git checkout pull/24235
$ git pull https://git.openjdk.org/jdk.git pull/24235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24235

View PR using the GUI difftool:
$ git pr show -t 24235

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24235.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
grahamc Graham Christensen
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI

Reviewed-by: serb, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

  • 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • c2a4fed: 8348907: Stress times out when is executed with ZGC
  • 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
  • 1d205f5: 8352716: (tz) Update Timezone Data to 2025b
  • a2a64da: 8352588: GenShen: Enabling JFR asserts when getting GCId
  • 79bffe2: 8349361: C2: RShiftL should support all applicable transformations that RShiftI does
  • ... and 71 more: https://git.openjdk.org/jdk/compare/0cb110ebb7f8d184dd855f64c5dd7924c8202b3d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 25, 2025
@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@aivanov-jdk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 25, 2025
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

Going to push as commit 41f3eea.
Since your change was applied there have been 92 commits pushed to the master branch:

  • e2cd70a: 8351151: Clean up x86 template interpreter after 32-bit x86 removal
  • b990780: 8352393: AIX: Problem list serviceability/attach/AttachAPIv2/StreamingOutputTest.java
  • 927aeb2: 8352617: IR framework test TestCompileCommandFileWriter.java runs TestCompilePhaseCollector instead of itself
  • 0bfa636: 8352426: RelocIterator should correctly handle nullptr address of relocation data
  • b7ffd22: 8352980: Purge infrastructure for FP-to-bits interpreter intrinsics after 32-bit x86 removal
  • 9a87e21: 8352800: [PPC] OpenJDK fails to build on PPC after JDK-8350106
  • 4100dc9: 8350801: Add a code signing hook to the JDK build system
  • 8a40498: 8352678: Opensource few JMenuItem tests
  • 66b5dba: 8350988: Consolidate Identity of self-inverse operations
  • 1007811: 8352897: RISC-V: Change default value for UseConservativeFence
  • ... and 82 more: https://git.openjdk.org/jdk/compare/0cb110ebb7f8d184dd855f64c5dd7924c8202b3d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025
@openjdk openjdk bot closed this Mar 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@aivanov-jdk Pushed as commit 41f3eea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@aivanov-jdk aivanov-jdk deleted the 8352624-passFail-splitUI-code branch March 27, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

3 participants