-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8352678: Opensource few JMenuItem tests #24273
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 103 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
* @test | ||
* @bug 4207339 | ||
* @summary Verifies HTML label support for MenuItems | ||
* @library /open/test/jdk/java/awt/regtesthelpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @library /open/test/jdk/java/awt/regtesthelpers | |
* @library /java/awt/regtesthelpers |
* @bug 4402082 | ||
* @requires (os.family == "windows") | ||
* @summary Tests that JMenuItem accelerator is rendered correctly. | ||
* @library /open/test/jdk/java/awt/regtesthelpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @library /open/test/jdk/java/awt/regtesthelpers | |
* @library /java/awt/regtesthelpers |
* @bug 6197830 | ||
* @requires (os.family == "linux") | ||
* @summary Fix for 4729669 does not work on Motif and GTK look and feels | ||
* @library /open/test/jdk/java/awt/regtesthelpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @library /open/test/jdk/java/awt/regtesthelpers | |
* @library /java/awt/regtesthelpers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch..Thanks..Updated..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/integrate |
Going to push as commit 8a40498.
Your commit was automatically rebased without conflicts. |
Few JMenuItem tests are opensourced
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24273/head:pull/24273
$ git checkout pull/24273
Update a local copy of the PR:
$ git checkout pull/24273
$ git pull https://git.openjdk.org/jdk.git pull/24273/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 24273
View PR using the GUI difftool:
$ git pr show -t 24273
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24273.diff
Using Webrev
Link to Webrev Comment