Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8352678: Opensource few JMenuItem tests #24273

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Mar 27, 2025

Few JMenuItem tests are opensourced


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352678: Opensource few JMenuItem tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24273/head:pull/24273
$ git checkout pull/24273

Update a local copy of the PR:
$ git checkout pull/24273
$ git pull https://git.openjdk.org/jdk.git pull/24273/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24273

View PR using the GUI difftool:
$ git pr show -t 24273

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24273.diff

Using Webrev

Link to Webrev Comment

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 27, 2025

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352678: Opensource few JMenuItem tests

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 103 new commits pushed to the master branch:

  • 66b5dba: 8350988: Consolidate Identity of self-inverse operations
  • 1007811: 8352897: RISC-V: Change default value for UseConservativeFence
  • 7853415: 8352218: RISC-V: Zvfh requires RVV
  • 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • c2a4fed: 8348907: Stress times out when is executed with ZGC
  • 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
  • ... and 93 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Mar 27, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 27, 2025

Webrevs

* @test
* @bug 4207339
* @summary Verifies HTML label support for MenuItems
* @library /open/test/jdk/java/awt/regtesthelpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @library /open/test/jdk/java/awt/regtesthelpers
* @library /java/awt/regtesthelpers

* @bug 4402082
* @requires (os.family == "windows")
* @summary Tests that JMenuItem accelerator is rendered correctly.
* @library /open/test/jdk/java/awt/regtesthelpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @library /open/test/jdk/java/awt/regtesthelpers
* @library /java/awt/regtesthelpers

* @bug 6197830
* @requires (os.family == "linux")
* @summary Fix for 4729669 does not work on Motif and GTK look and feels
* @library /open/test/jdk/java/awt/regtesthelpers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @library /open/test/jdk/java/awt/regtesthelpers
* @library /java/awt/regtesthelpers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch..Thanks..Updated..

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 27, 2025
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 27, 2025

Going to push as commit 8a40498.
Since your change was applied there have been 103 commits pushed to the master branch:

  • 66b5dba: 8350988: Consolidate Identity of self-inverse operations
  • 1007811: 8352897: RISC-V: Change default value for UseConservativeFence
  • 7853415: 8352218: RISC-V: Zvfh requires RVV
  • 2483340: 8352579: Refactor CDS legacy optimization for lambda proxy classes
  • 1397ee5: 8334322: Misleading values of keys in jpackage resource bundle
  • 441bd12: 8352812: remove useless class and function parameter in SuspendThread impl
  • e83cccf: 8352948: Remove leftover runtime_x86_32.cpp after 32-bit x86 removal
  • 5672a93: 8348400: GenShen: assert(ShenandoahHeap::heap()->is_full_gc_in_progress() || (used_regions_size() <= _max_capacity)) failed: Cannot use more than capacity #
  • c2a4fed: 8348907: Stress times out when is executed with ZGC
  • 5392674: 8352766: Problemlist hotspot tier1 tests requiring tools that are not included in static JDK
  • ... and 93 more: https://git.openjdk.org/jdk/compare/96305e0953a2a3b41bc32b1c584a1a29901a37fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 27, 2025
@openjdk openjdk bot closed this Mar 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 27, 2025
@openjdk
Copy link

openjdk bot commented Mar 27, 2025

@prsadhuk Pushed as commit 8a40498.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8352678 branch March 27, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

None yet

2 participants