8352114: New test runtime/interpreter/CountBytecodesTest.java is failing

[dbriemann]

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352114: New test runtime/interpreter/CountBytecodesTest.java is failing (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24281/head:pull/24281
$ git checkout pull/24281

Update a local copy of the PR:
$ git checkout pull/24281
$ git pull https://git.openjdk.org/jdk.git pull/24281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24281

View PR using the GUI difftool:
$ git pr show -t 24281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24281.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dbriemann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[dbriemann]

Hi @dholmes-ora ,
could you please verify that this fixes the issue? Thanks.

[openjdk]

@dbriemann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352114: New test runtime/interpreter/CountBytecodesTest.java is failing

Reviewed-by: dholmes, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 23e3b3f: 8351156: C1: Remove FPU stack support after 32-bit x86 removal
• 2592513: 8350577: Fix missing Assertion Predicates when splitting loops
• 59629f8: 8351040: [REDO] Protection zone for easier detection of accidental zero-nKlass use
• 8cbadf7: 8317976: Optimize SIMD sort for AMD Zen 4
• b9d7a75: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class
• 895aabc: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized
• 3d2c3cd: 8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2
• c70ad6a: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call
• da3bb06: 8352685: Opensource JInternalFrame tests - series2
• d809033: 8341775: Duplicate manifest files are removed by jarsigner after signing
• ... and 21 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora, @TheRealMDoerr) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@dbriemann The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a5c6ece1)

[dholmes-ora]

I will test this on Monday.

[dholmes-ora]

Looks good and passes our failing test run.

Thanks

[TheRealMDoerr]

LGTM.

[dbriemann]

Thank you for the reviews!
/integrate

[openjdk]

@dbriemann
Your change (at version a5c6ece) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit 79d0c94.
Since your change was applied there have been 31 commits pushed to the master branch:

• 23e3b3f: 8351156: C1: Remove FPU stack support after 32-bit x86 removal
• 2592513: 8350577: Fix missing Assertion Predicates when splitting loops
• 59629f8: 8351040: [REDO] Protection zone for easier detection of accidental zero-nKlass use
• 8cbadf7: 8317976: Optimize SIMD sort for AMD Zen 4
• b9d7a75: 8352879: TestPeriod.java and TestGetContentType.java run wrong test class
• 895aabc: 8351233: [ASAN] avx2-emu-funcs.hpp:151:20: error: ‘D.82188’ is used uninitialized
• 3d2c3cd: 8352970: Remove unnecessary Windows version check in Win32ShellFolderManager2
• c70ad6a: 8352906: stdout/err.encoding on Windows set by incorrect Win32 call
• da3bb06: 8352685: Opensource JInternalFrame tests - series2
• d809033: 8341775: Duplicate manifest files are removed by jarsigner after signing
• ... and 21 more: https://git.openjdk.org/jdk/compare/41f3eea9b2b7bd74d5f125dedfe107ab5b0bed26...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @dbriemann Pushed as commit 79d0c94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.