Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider #1895

Closed

Conversation

RealLucy
Copy link
Contributor

@RealLucy RealLucy commented May 24, 2023

Hi all,

this backport is for parity with 11.0.20-oracle.

This pull request contains a backport of commit f235955e from the openjdk/jdk repository.

The commit being backported was authored by Sean Mullan on 26 May 2022 and was reviewed by Weijun Wang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1895/head:pull/1895
$ git checkout pull/1895

Update a local copy of the PR:
$ git checkout pull/1895
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1895

View PR using the GUI difftool:
$ git pr show -t 1895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1895.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 24, 2023

👋 Welcome back lucy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f235955eefb1141a2e72116dfcf345e40416f059 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider May 24, 2023
@openjdk
Copy link

openjdk bot commented May 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 24, 2023

@RealLucy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 24, 2023
@mlbridge
Copy link

mlbridge bot commented May 24, 2023

Webrevs

@RealLucy
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented May 25, 2023

Going to push as commit 5fa213a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c0ae141: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 25, 2023
@openjdk openjdk bot closed this May 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 25, 2023
@openjdk
Copy link

openjdk bot commented May 25, 2023

@RealLucy Pushed as commit 5fa213a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant