8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression

[apavlyutkin]

Hi!

Here is backport of JDK-8275233 that fixes incorrect javac -g flag processing. The issue was introduced by JDK-8200301. It prevents proper debug info generation for labmdas, in particular it causes wrong line numbers in stack trace upon throwing an exception from a labmda fucntion.

The original patch applied cleanly

Verification (amd64/20.04LTS): test/langtools/tools/javac/lambda/deduplication/DeduplicationDebugInfo.java (new test)
Regression (amd64/20.04LTS): test/langtools

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1904/head:pull/1904
$ git checkout pull/1904

Update a local copy of the PR:
$ git checkout pull/1904
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1904/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1904

View PR using the GUI difftool:
$ git pr show -t 1904

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1904.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275233: Incorrect line number reported in exception stack trace thrown from a lambda expression

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

• 2e01473: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
• 5fa213a: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
• c0ae141: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (34c46930)

[apavlyutkin]

/integrate

[openjdk]

@apavlyutkin
Your change (at version 34c4693) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit 682728e.
Since your change was applied there have been 3 commits pushed to the master branch:

• 2e01473: 8278434: timeouts in test java/time/test/java/time/format/TestZoneTextPrinterParser.java
• 5fa213a: 8287246: DSAKeyValue should check for missing params instead of relying on KeyFactory provider
• c0ae141: 8275735: [linux] Remove deprecated Metrics api (kernel memory limit)

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @apavlyutkin Pushed as commit 682728e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.