-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML #1907
Conversation
👋 Welcome back Nagata-Haruhito! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Would you please review this PR? |
Please, first review, then label fix-request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@Nagata-Haruhito This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 31 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thank you for your advice. |
Should I re-label "11u-fix-request" on JBS ? Or can I type |
The jdk11u-fix-request label is on the JBS issue, but no jdk11u-fix-yes, so we're still waiting for the maintainer decision before adding /integrate. |
I have confirmed jdk11u-fix-yes label is added on JBS. Thank you very match. |
/integrate |
@Nagata-Haruhito |
/integrate |
/sponsor |
@phohensee Only the author (@Nagata-Haruhito) is allowed to issue the |
Going to push as commit ad283ae.
Your commit was automatically rebased without conflicts. |
@phohensee @Nagata-Haruhito Pushed as commit ad283ae. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Is there a reason that |
I want to backport JDK-8268457 to JDK11u.
This is almost clean except lastmodified month.
Note, included test is broken, it was fixed with JDK-8274606,
I intend to follow up with its backport same as jdk17u.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1907/head:pull/1907
$ git checkout pull/1907
Update a local copy of the PR:
$ git checkout pull/1907
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1907/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1907
View PR using the GUI difftool:
$ git pr show -t 1907
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1907.diff
Webrev
Link to Webrev Comment