Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out #1923

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jun 2, 2023

Backport 8279536


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1923/head:pull/1923
$ git checkout pull/1923

Update a local copy of the PR:
$ git checkout pull/1923
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1923

View PR using the GUI difftool:
$ git pr show -t 1923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1923.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ff0cb98965a0b6be2f6c399e4645630c10b3466e 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out Jun 2, 2023
@openjdk
Copy link

openjdk bot commented Jun 2, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 2, 2023

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 2, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2023

Webrevs

@MBaesken
Copy link
Member Author

MBaesken commented Jun 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 6, 2023

Going to push as commit 3207e73.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 81bb36e: 8301491: C2: java.lang.StringUTF16::indexOfChar intrinsic called with negative character argument
  • d917caa: 8297730: C2: Arraycopy intrinsic throws incorrect exception
  • 3ba2a18: 8223573: Replace wildcard address with loopback or local host in tests - part 4
  • 3cdce91: 8217237: HttpClient does not deal well with multi-valued WWW-Authenticate challenge headers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 6, 2023
@openjdk openjdk bot closed this Jun 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 6, 2023
@openjdk
Copy link

openjdk bot commented Jun 6, 2023

@MBaesken Pushed as commit 3207e73.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant