Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223856: Replace wildcard address with loopback or local host in tests - part 8 #1932

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jun 5, 2023

I backport this to fix some issues we see in our CI.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223856: Replace wildcard address with loopback or local host in tests - part 8 (Sub-task - "3")

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/1932/head:pull/1932
$ git checkout pull/1932

Update a local copy of the PR:
$ git checkout pull/1932
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/1932/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1932

View PR using the GUI difftool:
$ git pr show -t 1932

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/1932.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd9e3c1b1380e1115b6e46d377877a7045857068 8223856: Replace wildcard address with loopback or local host in tests - part 8 Jun 5, 2023
@openjdk
Copy link

openjdk bot commented Jun 5, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 5, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223856: Replace wildcard address with loopback or local host in tests - part 8

Fixes some intermittent test failures by replacing wildcard with loopback - or retrying once.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 7a35741: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale
  • 3207e73: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 5, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jun 7, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jun 7, 2023

Going to push as commit e3dd9dd.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 7a35741: 8158880: test/java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale
  • 3207e73: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2023
@openjdk openjdk bot closed this Jun 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2023
@openjdk
Copy link

openjdk bot commented Jun 7, 2023

@GoeLin Pushed as commit e3dd9dd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant