-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values #2031
Conversation
👋 Welcome back lucy! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import mistake makes the test not compile. Looks good otherwise.
*/ | ||
import jdk.test.lib.containers.docker.Common; | ||
import jdk.test.lib.containers.docker.DockerRunOptions; | ||
import jdk.test.lib.containers.docker.DockerTestUtils; | ||
import jdk.test.lib.sun.hotspot.WhiteBox; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
import sun.hotspot.WhiteBox;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for approving this PR, @jerboaa
And thank you for pointing me to the error. I was in a hurry to make the SAP nightmare deadline.
Learning? If you can't make it with diligence, don't do it. As always.
import stmt is fixed.
@RealLucy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 19 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 1a99b6e.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 11.0.21-oracle.
Whitebox obviously differs in location between 11 and head. Needed adaptations.
In all affected files, some chunks did not apply. Manual resolution was straightforward.
GHA and SAP-internal tests succeeded.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2031/head:pull/2031
$ git checkout pull/2031
Update a local copy of the PR:
$ git checkout pull/2031
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2031/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2031
View PR using the GUI difftool:
$ git pr show -t 2031
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2031.diff
Webrev
Link to Webrev Comment