8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

[apangin]

Please consider the proposed backport of the fix for JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly.

Customers complain about unexpected java.net.SocketTimeoutException when profiling an application running on JDK 11.0.20.

The original patch applies cleanly with a trivial adjustment in make/common/TestFilesCompilation.gmk, where $$ has been replaced with $.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly (Bug - P4)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2089/head:pull/2089
$ git checkout pull/2089

Update a local copy of the PR:
$ git checkout pull/2089
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2089/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2089

View PR using the GUI difftool:
$ git pr show -t 2089

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2089.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back apangin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 00: Full (3681754e)

[openjdk]

@apangin
The label net is not a valid label.
These labels are valid:

[openjdk]

@apangin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectly

PlainSocketImpl.socketAccept() handles EINTR incorrectly

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

• b77c161: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• b984b0a: 8293107: GHA: Bump to Ubuntu 22.04
• c86ba43: 8312972: Bump update version for OpenJDK: jdk-11.0.22
• 39986e0: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java
• 749ecd5: Merge
• fffaff3: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• 1b3c516: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1
• 89a88f0: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
• e1b839e: 8302182: Update Public Suffix List to 88467c9
• 81806b7: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/ee128b2f6c24410ad04cf9bb662fc0423b919427...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[apangin]

/integrate

[openjdk]

@apangin
Your change (at version 3681754) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit d76e6ea.
Since your change was applied there have been 21 commits pushed to the master branch:

• b77c161: 8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()
• b984b0a: 8293107: GHA: Bump to Ubuntu 22.04
• c86ba43: 8312972: Bump update version for OpenJDK: jdk-11.0.22
• 39986e0: 8314086: [11u] A typo in the fix for JDK-8312462 is causing test failure in ChildAlwaysOnTopTest.java
• 749ecd5: Merge
• fffaff3: 8313765: Invalid CEN header (invalid zip64 extra data field size)
• 1b3c516: 8314678: Bump update version for OpenJDK: jdk-11.0.20.1
• 89a88f0: 8276651: java/lang/ProcessHandle tests fail with "RuntimeException: Input/output error" in java.lang.ProcessHandleImpl$Info.info0
• e1b839e: 8302182: Update Public Suffix List to 88467c9
• 81806b7: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612
• ... and 11 more: https://git.openjdk.org/jdk11u-dev/compare/ee128b2f6c24410ad04cf9bb662fc0423b919427...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @apangin Pushed as commit d76e6ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.