Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr" #2175

Closed

Conversation

luchenlin
Copy link
Contributor

@luchenlin luchenlin commented Oct 11, 2023

I backport this for parity with 11.0.22-oracle.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8259266 needs maintainer approval
  • JDK-8260431 needs maintainer approval

Issues

  • JDK-8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr" (Bug - P4 - Approved)
  • JDK-8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2175/head:pull/2175
$ git checkout pull/2175

Update a local copy of the PR:
$ git checkout pull/2175
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2175/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2175

View PR using the GUI difftool:
$ git pr show -t 2175

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2175.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 11, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d63388c00c48e0a08609ae63217f51e474c236ea 8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr" Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Oct 11, 2023
@luchenlin
Copy link
Contributor Author

/issue add JDK-8260431

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@luchenlin
Adding additional issue to issue list: 8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr".

@mlbridge
Copy link

mlbridge bot commented Oct 11, 2023

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Combinationof two clean backports.
LGTM

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@luchenlin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259266: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo 2<' missing from stdout/stderr"
8260431: com/sun/jdi/JdbOptions.java failed with "RuntimeException: 'prop[boo] = >foo<' missing from stdout/stderr"

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 94d3648: 8303607: SunMSCAPI provider leaks memory and keys
  • 363855d: 8233000: Mark vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize test as stress test
  • 84bc252: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • efc3f4a: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 4780287: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
  • 75b7c79: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • 6e34daa: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • 2a39b98: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
  • 8336e3e: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • a75f34f: 8232933: Javac inferred type does not conform to equality constraint
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/0aba9b7b5c74ac6530cc872ac5cbed8f716f80ac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 13, 2023
@luchenlin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2023
@openjdk
Copy link

openjdk bot commented Oct 13, 2023

@luchenlin
Your change (at version 9aad7d5) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 15, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 15, 2023

Going to push as commit c780db7.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 94d3648: 8303607: SunMSCAPI provider leaks memory and keys
  • 363855d: 8233000: Mark vmTestbase/vm/mlvm/meth/stress/compiler/deoptimize test as stress test
  • 84bc252: 8289547: Update javax/swing/Popup/TaskbarPositionTest.java
  • efc3f4a: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 4780287: 8252713: jtreg time out of CtrlASCII.java seems to hang the Xserver.
  • 75b7c79: 8300405: Screen capture for test JFileChooserSetLocationTest.java, failure case
  • 6e34daa: 8282404: DrawStringWithInfiniteXform.java failed with "RuntimeException: drawString with InfiniteXform transform takes long time"
  • 2a39b98: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
  • 8336e3e: 8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere
  • a75f34f: 8232933: Javac inferred type does not conform to equality constraint
  • ... and 3 more: https://git.openjdk.org/jdk11u-dev/compare/0aba9b7b5c74ac6530cc872ac5cbed8f716f80ac...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 15, 2023
@openjdk openjdk bot closed this Oct 15, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 15, 2023
@openjdk
Copy link

openjdk bot commented Oct 15, 2023

@GoeLin @luchenlin Pushed as commit c780db7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants