8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

[tabjy]

a clean backport of JDK-8240235.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8240235 needs maintainer approval

Issue

• JDK-8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2215/head:pull/2215
$ git checkout pull/2215

Update a local copy of the PR:
$ git checkout pull/2215
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2215

View PR using the GUI difftool:
$ git pr show -t 2215

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2215.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kxu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[tabjy]

/backport jdk15u

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @tabjy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@tabjy The target repository jdk15u is not a valid target for backports.
List of valid target repositories: openjdk/jdk, openjdk/jdk11u, openjdk/jdk11u-dev, openjdk/jdk17u, openjdk/jdk17u-dev, openjdk/jdk19u, openjdk/jdk20u, openjdk/jdk21, openjdk/jdk21u, openjdk/jdk7u, openjdk/jdk8u, openjdk/jdk8u-dev, openjdk/jfx, openjdk/jfx20u, openjdk/jfx21u, openjdk/lilliput-jdk17u, openjdk/lilliput-jdk21u, openjdk/shenandoah-jdk8u, openjdk/shenandoah-jdk8u-dev.
Supplying the organization/group prefix is optional.

[tabjy]

/backport jdk

[openjdk]

@tabjy Backport for repo openjdk/jdk on branch master was successfully enabled and will be performed once this pull request has been integrated. Further instructions will be provided at that time.

[mlbridge]

Webrevs

• 00: Full (537c4f2b)

[tabjy]

/approval request Fix Request (jdk11u)
Cleanly backported to match Oracle parity 11.0.22-oracle. Low risk for test library fixes. All tests pass on GHA.

[openjdk]

@tabjy
8240235: The approval request has been created successfully.

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8240235: The approval request has been approved.

[openjdk]

@tabjy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8240235: jdk.test.lib.util.JarUtils updates jar files incorrectly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 365dacc: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
• f6a05cf: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
• c922821: 8301167: Update VerifySignedJar to actually exercise and test verification
• a28f66b: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• ce38b3e: 8273804: Platform.isTieredSupported should handle the no-compiler case
• 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
• 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[tabjy]

/sponsor

[openjdk]

@tabjy Only Committers are allowed to sponsor changes.

[tabjy]

/integrate

[openjdk]

@tabjy
Your change (at version 537c4f2) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit a6ee5aa.
Since your change was applied there have been 7 commits pushed to the master branch:

• 365dacc: 8309095: Remove UTF-8 character from TaskbarPositionTest.java
• f6a05cf: 8307165: java/awt/dnd/NoFormatsDropTest/NoFormatsDropTest.java timed out
• c922821: 8301167: Update VerifySignedJar to actually exercise and test verification
• a28f66b: 8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines
• ce38b3e: 8273804: Platform.isTieredSupported should handle the no-compiler case
• 2835c6a: 8254711: Add java.security.Provider.getService JFR Event
• 129e856: 8266249: javax/swing/JPopupMenu/7156657/bug7156657.java fails on macOS

Your commit was automatically rebased without conflicts.

[openjdk]

Creating backport for repo openjdk/jdk on branch master

/backport openjdk/jdk master

[openjdk]

@phohensee @tabjy Pushed as commit a6ee5aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[openjdk]

@openjdk[bot] @tabjy Could not apply backport a6ee5aa7 to openjdk/jdk because the change is already present in the target.