Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8251177: [macosx] The text "big" is truncated in JTabbedPane #2220

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 26, 2023

I backport this for parity with 11.0.19-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8251177 needs maintainer approval

Issue

  • JDK-8251177: [macosx] The text "big" is truncated in JTabbedPane (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2220/head:pull/2220
$ git checkout pull/2220

Update a local copy of the PR:
$ git checkout pull/2220
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2220/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2220

View PR using the GUI difftool:
$ git pr show -t 2220

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2220.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 16ebe40a1bcd1fe43126fe1dca27bb64cb12de16 8251177: [macosx] The text "big" is truncated in JTabbedPane Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 29, 2023

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8251177: [macosx] The text "big" is truncated in JTabbedPane

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9be4d3f: 8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong
  • 35000fb: 8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region
  • a4080b9: 8217329: JTREG: Clean up, remove unused imports in gc folder

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 29, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 30, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2023

Going to push as commit 53acd95.
Since your change was applied there have been 6 commits pushed to the master branch:

  • dd1994e: 8231931: [TESTBUG] serviceability/sa/TestUniverse.java looks for wrong string with Shenandoah
  • cf13e82: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • b9936cd: 8221396: Clean up serviceability/sa/TestUniverse.java
  • 9be4d3f: 8289917: Metadata for regionsRefilled of G1EvacuationStatistics event is wrong
  • 35000fb: 8213898: CDS dumping of springboot asserts in G1ArchiveAllocator::alloc_new_region
  • a4080b9: 8217329: JTREG: Clean up, remove unused imports in gc folder

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2023
@openjdk openjdk bot closed this Oct 30, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2023
@openjdk
Copy link

openjdk bot commented Oct 30, 2023

@GoeLin Pushed as commit 53acd95.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant