8255068: [JVMCI] errors during compiler creation can be hidden #2230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an almost clean backport of JDK-8255068 [JVMCI] errors during compiler creation can be hidden
Backport-of: openjdk/jdk@6020991
The original patch does not apply cleanly to 11u; it references a
creatingCompiler
boolean was introduced in JDK-8220623 for JDK 13. I removed lines related to this flag.All tests passed with GHA.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2230/head:pull/2230
$ git checkout pull/2230
Update a local copy of the PR:
$ git checkout pull/2230
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2230/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2230
View PR using the GUI difftool:
$ git pr show -t 2230
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2230.diff
Webrev
Link to Webrev Comment