Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8255068: [JVMCI] errors during compiler creation can be hidden #2230

Closed
wants to merge 1 commit into from

Conversation

tabjy
Copy link
Member

@tabjy tabjy commented Oct 27, 2023

an almost clean backport of JDK-8255068 [JVMCI] errors during compiler creation can be hidden

Backport-of: openjdk/jdk@6020991

The original patch does not apply cleanly to 11u; it references a creatingCompiler boolean was introduced in JDK-8220623 for JDK 13. I removed lines related to this flag.

All tests passed with GHA.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8255068 needs maintainer approval

Issue

  • JDK-8255068: [JVMCI] errors during compiler creation can be hidden (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/2230/head:pull/2230
$ git checkout pull/2230

Update a local copy of the PR:
$ git checkout pull/2230
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/2230/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2230

View PR using the GUI difftool:
$ git pr show -t 2230

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/2230.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2023

👋 Welcome back kxu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6020991530c0efe81fd203f35a7352247aedafeb 8255068: [JVMCI] errors during compiler creation can be hidden Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 27, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2023

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Nov 8, 2023

@tabjy This is a JVMCI change and has the jdk11u-jvmci-defer label. The primary user of JVMCI is GraalVM and as far as I know we don't have any more consumers of that for JDK 11. It seems not worth the risk to include it in that stage of the JDK 11 lifecycle.

@tabjy
Copy link
Member Author

tabjy commented Nov 8, 2023

@jerboaa Understood. Thanks for your clarification. Sorry that I wasn't aware of this!

@tabjy tabjy closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants